Re: [PATCH v3 3/7] Add channels parameter in migrate_qmp_fail

[Het Gala]

On 06/03/24 8:10 pm, Fabiano Rosas wrote:

> Het Gala <het.gala@nutanix.com> writes:
>
> > Alter migrate_qmp_fail() to allow both uri and channels
> > independently. For channels, convert string to a Dict.
> > No dealing with migrate_get_socket_address() here because
> > we will fail before starting the migration anyway.
> >
> > Signed-off-by: Het Gala <het.gala@nutanix.com>
> > Suggested-by: Fabiano Rosas <farosas@suse.de>
> > ---
> >  tests/qtest/migration-helpers.c | 15 +++++++++++++--
> >  tests/qtest/migration-helpers.h |  5 +++--
> >  tests/qtest/migration-test.c    |  4 ++--
> >  3 files changed, 18 insertions(+), 6 deletions(-)
> >
> > diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c
> > index 9af3c7d4d5..478c1f259b 100644
> > --- a/tests/qtest/migration-helpers.c
> > +++ b/tests/qtest/migration-helpers.c
> > @@ -92,17 +92,28 @@ bool migrate_watch_for_events(QTestState *who, const char *name,
> >      return false;
> >  }
> >  
> > -void migrate_qmp_fail(QTestState *who, const char *uri, const char *fmt, ...)
> > +void migrate_qmp_fail(QTestState *who, const char *uri,
> > +                      const char *channels, const char *fmt, ...)
> >  {
> >      va_list ap;
> >      QDict *args, *err;
> > +    Error *error_abort = NULL;
> >       
> The error_abort needs to be the one defined in error.c. Just remove this
> line.
>     
    Ack.

Regards

Het Gala