Re: [PATCH] char: Slightly better error reporting when chardev is in use

[Markus Armbruster]

Marc-André Lureau <marcandre.lureau@gmail.com> writes:

> Hi
>
> On Wed, Mar 6, 2024 at 12:15 PM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Both
>>
>>     $ qemu-system-x86_64 -chardev null,id=chr0,mux=on -mon chardev=chr0 -mon 
>> chardev=chr0 -mon chardev=chr0 -mon chardev=chr0 -mon chardev=chr0
>>
>> and
>>
>>     $ qemu-system-x86_64 -chardev null,id=chr0 -mon chardev=chr0 -mon 
>> chardev=chr0
>> fail with
>>
>>     qemu-system-x86_64: -mon chardev=chr0: Device 'chr0' is in use
>>
>> Improve to
>>
>>     qemu-system-x86_64: -mon chardev=chr0: too many uses of multiplexed 
>> chardev 'chr0' (maximum is 4)
>>
>> and
>>
>>     qemu-system-x86_64: -mon chardev=chr0: chardev 'chr0' is already in use
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> lgtm
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Thanks!

[...]

> QERR_DEVICE_IN_USE is now left with a single user in blockdev.c. Is it worth 
> it?

Nope, that one needs to go, too.  How to reproduce it isn't obvious to
me.  I'll figure it out.