Re: [PATCH v2 11/13] contrib/elf2dmp: Build only for little endian host

[Akihiko Odaki]

On 2024/03/05 22:33, Peter Maydell wrote:
> On Tue, 5 Mar 2024 at 07:37, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
> > elf2dmp assumes little endian host in many places.
> >
> > Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> > ---
> >   contrib/elf2dmp/meson.build | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/contrib/elf2dmp/meson.build b/contrib/elf2dmp/meson.build
> > index 6707d43c4fa5..046569861f7a 100644
> > --- a/contrib/elf2dmp/meson.build
> > +++ b/contrib/elf2dmp/meson.build
> > @@ -1,4 +1,4 @@
> > -if curl.found()
> > +if curl.found() and host_machine.endian() == 'little'
> >     executable('elf2dmp', files('main.c', 'addrspace.c', 'download.c', 'pdb.c', 
> > 'qemu_elf.c'), genh,
> >                dependencies: [glib, curl],
> >                install: true)
>
> If it assumes a little-endian host that is a bug and we
> should fix it, not just disable building the tool on
> big-endian systems.

I will accept if someone submits a proper fix in the future, but I'm not 
going to put effort on that. This is the best thing I can offer for now.

Regards,
Akihiko Odaki