[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0" SMP con
From: |
Prasad Pandit |
Subject: |
Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations |
Date: |
Wed, 6 Mar 2024 10:19:41 +0530 |
Hello Zhao,
On Wed, 6 Mar 2024 at 08:49, Zhao Liu <zhao1.liu@linux.intel.com> wrote:
>> then checking 'config->has_maxcpus ?' above is probably not required I
>> think. It could just be
>>
>> maxcpus = config->maxcpus
>
> Yes.
>
> > If a user does not specify config->maxcpus with -smp option, then it
> > could default to zero(0) in 'config' parameter? (same for other config
> > fields)
>
> Yes. I could post another series for this cleanup soon.
> The above change you suggested doesn't require API changes ;-).
* Great! (Communication is the most difficult skill to master. :))
* If you plan to send a separate patch for above refactoring, then I'd
add Reviewed-by for this one.
Reviewed-by: Prasad Pandit <pjp@fedoraproject.org>
Thank you.
---
- Prasad
- [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations, Zhao Liu, 2024/03/03
- Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations, Thomas Huth, 2024/03/04
- Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations, Prasad Pandit, 2024/03/04
- Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations, Zhao Liu, 2024/03/04
- Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations, Prasad Pandit, 2024/03/04
- Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations, Zhao Liu, 2024/03/05
- Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations, Prasad Pandit, 2024/03/05
- Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations, Zhao Liu, 2024/03/05
- Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations,
Prasad Pandit <=
- Re: [PATCH] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations, Zhao Liu, 2024/03/06