[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 1/9] qdev: Add a granule_mode property
From: |
Eric Auger |
Subject: |
[PATCH v6 1/9] qdev: Add a granule_mode property |
Date: |
Tue, 5 Mar 2024 19:06:19 +0100 |
Introduce a new enum type property allowing to set an
IOMMU granule. Values are 4k, 8k, 16k, 64k and host.
This latter indicates the vIOMMU granule will match
the host page size.
A subsequent patch will add such a property to the
virtio-iommu device.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
---
v5 -> v6
- remove #include "hw/virtio/virtio-iommu.h" (Zhenzhong)
v4 -> v5
- remove code that can be automatically generated
and add the new enum in qapi/virtio.json (Philippe).
Added Phild's SOB. low case needs to be used due to
the Jason generation.
v3 -> v4:
- Add 8K
---
qapi/virtio.json | 18 ++++++++++++++++++
include/hw/qdev-properties-system.h | 3 +++
hw/core/qdev-properties-system.c | 14 ++++++++++++++
3 files changed, 35 insertions(+)
diff --git a/qapi/virtio.json b/qapi/virtio.json
index a79013fe89..95745fdfd7 100644
--- a/qapi/virtio.json
+++ b/qapi/virtio.json
@@ -957,3 +957,21 @@
{ 'struct': 'DummyVirtioForceArrays',
'data': { 'unused-iothread-vq-mapping': ['IOThreadVirtQueueMapping'] } }
+
+##
+# @GranuleMode:
+#
+# @4k: granule page size of 4KiB
+#
+# @8k: granule page size of 8KiB
+#
+# @16k: granule page size of 16KiB
+#
+# @64k: granule page size of 64KiB
+#
+# @host: granule matches the host page size
+#
+# Since: 9.0
+##
+{ 'enum': 'GranuleMode',
+ 'data': [ '4k', '8k', '16k', '64k', 'host' ] }
diff --git a/include/hw/qdev-properties-system.h
b/include/hw/qdev-properties-system.h
index 06c359c190..626be87dd3 100644
--- a/include/hw/qdev-properties-system.h
+++ b/include/hw/qdev-properties-system.h
@@ -8,6 +8,7 @@ extern const PropertyInfo qdev_prop_macaddr;
extern const PropertyInfo qdev_prop_reserved_region;
extern const PropertyInfo qdev_prop_multifd_compression;
extern const PropertyInfo qdev_prop_mig_mode;
+extern const PropertyInfo qdev_prop_granule_mode;
extern const PropertyInfo qdev_prop_losttickpolicy;
extern const PropertyInfo qdev_prop_blockdev_on_error;
extern const PropertyInfo qdev_prop_bios_chs_trans;
@@ -47,6 +48,8 @@ extern const PropertyInfo qdev_prop_iothread_vq_mapping_list;
#define DEFINE_PROP_MIG_MODE(_n, _s, _f, _d) \
DEFINE_PROP_SIGNED(_n, _s, _f, _d, qdev_prop_mig_mode, \
MigMode)
+#define DEFINE_PROP_GRANULE_MODE(_n, _s, _f, _d) \
+ DEFINE_PROP_SIGNED(_n, _s, _f, _d, qdev_prop_granule_mode, GranuleMode)
#define DEFINE_PROP_LOSTTICKPOLICY(_n, _s, _f, _d) \
DEFINE_PROP_SIGNED(_n, _s, _f, _d, qdev_prop_losttickpolicy, \
LostTickPolicy)
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index 1a396521d5..b45e90edb2 100644
--- a/hw/core/qdev-properties-system.c
+++ b/hw/core/qdev-properties-system.c
@@ -679,6 +679,20 @@ const PropertyInfo qdev_prop_mig_mode = {
.set_default_value = qdev_propinfo_set_default_value_enum,
};
+/* --- GranuleMode --- */
+
+QEMU_BUILD_BUG_ON(sizeof(GranuleMode) != sizeof(int));
+
+const PropertyInfo qdev_prop_granule_mode = {
+ .name = "GranuleMode",
+ .description = "granule_mode values, "
+ "4k, 8k, 16k, 64k, host",
+ .enum_table = &GranuleMode_lookup,
+ .get = qdev_propinfo_get_enum,
+ .set = qdev_propinfo_set_enum,
+ .set_default_value = qdev_propinfo_set_default_value_enum,
+};
+
/* --- Reserved Region --- */
/*
--
2.41.0
- [PATCH v6 0/9] VIRTIO-IOMMU: Introduce aw-bits and granule options, Eric Auger, 2024/03/05
- [PATCH v6 1/9] qdev: Add a granule_mode property,
Eric Auger <=
- [PATCH v6 3/9] virtio-iommu: Change the default granule to the host page size, Eric Auger, 2024/03/05
- [PATCH v6 2/9] virtio-iommu: Add a granule property, Eric Auger, 2024/03/05
- [PATCH v6 4/9] qemu-options.hx: Document the virtio-iommu-pci granule option, Eric Auger, 2024/03/05
- [PATCH v6 5/9] virtio-iommu: Trace domain range limits as unsigned int, Eric Auger, 2024/03/05
- [PATCH v6 6/9] virtio-iommu: Add an option to define the input range width, Eric Auger, 2024/03/05
- [PATCH v6 7/9] hw/i386/q35: Set virtio-iommu aw-bits default value to 39, Eric Auger, 2024/03/05
- [PATCH v6 8/9] hw/arm/virt: Set virtio-iommu aw-bits default value to 48, Eric Auger, 2024/03/05