Re: [PATCH v3 1/4] hw/i386/pc: Remove "rtc_state" link again

[Peter Maydell]

On Sun, 3 Mar 2024 at 18:55, Bernhard Beschow <shentey@gmail.com> wrote:
>
> Commit 99e1c1137b6f "hw/i386/pc: Populate RTC attribute directly" made linking
> the "rtc_state" property unnecessary and removed it. Commit 84e945aad2d0 "vl,
> pc: turn -no-fd-bootchk into a machine property" accidently reintroduced the
> link. Remove it again since it is not needed.
>
> Fixes: 84e945aad2d0 "vl, pc: turn -no-fd-bootchk into a machine property"
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>

Ah, I did wonder when I was working with this code whether that
rtc_state link was really necessary.

We could now remove the rtc argument from the pc_cmos_init()
function, because we can guarantee that it's in x86ms->rtc,
which the function already has access to from its pcms argument.

thanks
-- PMM