[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/13] contrib/elf2dmp: Assume error by default
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 02/13] contrib/elf2dmp: Assume error by default |
Date: |
Tue, 5 Mar 2024 13:24:44 +0000 |
On Tue, 5 Mar 2024 at 07:36, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> A common construct in contrib/elf2dmp is to set "err" flag and goto
> in error paths. In such a construct, there is only one successful path
> while there are several error paths, so it will be more simpler to
> initialize "err" flag set, and clear it in the successful path.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v2 00/13] contrib/elf2dmp: Improve robustness, Akihiko Odaki, 2024/03/05
- [PATCH v2 05/13] contrib/elf2dmp: Always check for PA resolution failure, Akihiko Odaki, 2024/03/05
- [PATCH v2 03/13] contrib/elf2dmp: Continue even contexts are lacking, Akihiko Odaki, 2024/03/05
- [PATCH v2 12/13] contrib/elf2dmp: Use GPtrArray, Akihiko Odaki, 2024/03/05
- [PATCH v2 08/13] contrib/elf2dmp: Use lduw_le_p() to read PDB, Akihiko Odaki, 2024/03/05