[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/intc/apic: fix memory leak
|
From: |
Alex Bennée |
|
Subject: |
Re: [PATCH] hw/intc/apic: fix memory leak |
|
Date: |
Tue, 05 Mar 2024 13:21:09 +0000 |
|
User-agent: |
mu4e 1.12.1; emacs 29.1 |
Paolo Bonzini <pbonzini@redhat.com> writes:
> deliver_bitmask is allocated on the heap in apic_deliver(), but there
> are many paths in the function that return before the corresponding
> g_free() is reached. Fix this by switching to g_autofree and, while at
> it, also switch to g_new. Do the same in apic_deliver_irq() as well
> for consistency.
>
> Fixes: b5ee0468e9d ("apic: add support for x2APIC mode", 2024-02-14)
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro