Re: [RFC PATCH 2/2] gitlab-ci: add manual job to run Coverity

[Paolo Bonzini]

On Tue, Mar 5, 2024 at 9:52 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
> > +    - 'scripts/coverity-scan/run-coverity-scan --update-tools-only > 
> > update-tools.log 2>&1 || cat update-tools.log'
>
> Slightly shorter as:
>
>   .....   2>&1 | tee update-tools.log

Note that stdout/stderr are only dumped if the download fails, so tee
cannot be used.

> > +    - 'scripts/coverity-scan/run-coverity-scan --no-update-tools'
> > +  rules:
> > +    - if: '$COVERITY_TOKEN == null'
> > +      when: never
> > +    - if: '$COVERITY_EMAIL == null'
> > +      when: never
> > +    # Never included on upstream pipelines, except for schedules
> > +    - if: '$CI_PROJECT_NAMESPACE == $QEMU_CI_UPSTREAM && 
> > $CI_PIPELINE_SOURCE == "schedule" && $CI_COMMIT_REF_NAME == 
> > $CI_DEFAULT_BRANCH'
> > +      when: on_success
> > +    - if: '$CI_PROJECT_NAMESPACE == $QEMU_CI_UPSTREAM'
> > +      when: never
> > +    # Forks don't get any pipeline unless QEMU_CI=1 or QEMU_CI=2 is set
> > +    - if: '$QEMU_CI != "1" && $QEMU_CI != "2"'
> > +      when: never
> > +    # Always manual on forks even if $QEMU_CI == "2"
> > +    - when: manual
> > --
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Thanks! There will be a few small changes after I actually tested this
on a schedule, but nothing major.

Paolo