[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] tests: bump QOS_PATH_MAX_ELEMENT_SIZE again
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [RFC PATCH] tests: bump QOS_PATH_MAX_ELEMENT_SIZE again |
|
Date: |
Tue, 5 Mar 2024 11:02:14 +0100 |
On Mon, Mar 4, 2024 at 10:06 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>
> We "fixed" a bug with LTO builds with 100c459f194 (tests/qtest: bump
> up QOS_PATH_MAX_ELEMENT_SIZE) but it seems it has triggered again.
> Lets be more assertive raising QOS_PATH_MAX_ELEMENT_SIZE to make it go
> away again.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1186 (again)
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
The array is sized according to the maximum anticipated length of a
path on the graph. However, the worst case for a depth-first search is
to push all nodes on the graph. So it's not really LTO, it depends on
the ordering of the constructors.
I had a patch to implement the stack as a linked list, but I never
sent it because IIRC it caused failures that I never had time to
debug. This patch is okay as long as this information is included in
the commit message and/or code.
Paolo