Re: rutabaga 0.1.3

[Gurchetan Singh]

On Sat, Mar 2, 2024 at 6:38 AM Alyssa Ross <hi@alyssa.is> wrote:

Hi Gurchetan,

> >> > Would this be a suitable commit for the 0.1.3 release of rutabaga?
> >> >
> >> > https://chromium.googlesource.com/crosvm/crosvm/+/5dfd74a0680d317c6edf44138def886f47cb1c7c
> >> >
> >> > The gfxstream/AEMU commits would remain unchanged.
> >>
> >> That combination works for me.
> >
> > Just FYI, still working on it.  Could take 1-2 more weeks.
>
> FYI:
>
> https://android.googlesource.com/platform/hardware/google/gfxstream/+/refs/tags/v0.1.2-gfxstream-release
>
> https://android.googlesource.com/platform/hardware/google/aemu/+/refs/tags/v0.1.2-aemu-release
>
> https://chromium.googlesource.com/crosvm/crosvm/+/refs/tags/v0.1.3-rutabaga-release

Unlike the commit I tested for you, the commit that ended up being
tagged as v0.1.3-rutabaga-release doesn't work for me:

        qemu: The errno is EBADF: Bad file number
        qemu: CHECK failed in rutabaga_cmd_resource_map_blob() ../hw/display/virtio-gpu-rutabaga.c:655
        qemu: virtio_gpu_rutabaga_process_cmd: ctrl 0x208, error 0x1200
        qemu: CHECK failed in rutabaga_cmd_resource_unmap_blob() ../hw/display/virtio-gpu-rutabaga.c:723
        qemu: virtio_gpu_rutabaga_process_cmd: ctrl 0x209, error 0x1200
        qemu: The errno is EBADF: Bad file number
        qemu: CHECK failed in rutabaga_cmd_resource_map_blob() ../hw/display/virtio-gpu-rutabaga.c:655
        qemu: virtio_gpu_rutabaga_process_cmd: ctrl 0x208, error 0x1200
        qemu: CHECK failed in rutabaga_cmd_resource_unmap_blob() ../hw/display/virtio-gpu-rutabaga.c:723
        qemu: virtio_gpu_rutabaga_process_cmd: ctrl 0x209, error 0x1200
        qemu: The errno is EBADF: Bad file number
        qemu: CHECK failed in rutabaga_cmd_resource_map_blob() ../hw/display/virtio-gpu-rutabaga.c:655
        qemu: virtio_gpu_rutabaga_process_cmd: ctrl 0x208, error 0x1200
        qemu: invalid resource id
        qemu: CHECK failed in rutabaga_cmd_submit_3d() ../hw/display/virtio-gpu-rutabaga.c:341
        qemu: virtio_gpu_rutabaga_process_cmd: ctrl 0x207, error 0x1200
        qemu: CHECK failed in rutabaga_cmd_resource_unmap_blob() ../hw/display/virtio-gpu-rutabaga.c:723
        qemu: virtio_gpu_rutabaga_process_cmd: ctrl 0x209, error 0x1200

Thank you for the bug report .. does crrev.com/c/5342655 fix this for you? 

I bisected it to:

        commit f3dbf20eedadb135e2fd813474fbb9731d465f3a
        Author: Andrew Walbran <qwandor@google.com>
        Date:   Wed Nov 29 17:23:45 2023 +0000

            rutabaga_gfx: Uprev nix to 0.27.1

            The new version of nix uses OwnedFd in various places, which allows us
            to have less unsafe code.

            TEST=CQ
            BUG=b:293289578

            Change-Id: I61aa80c4105eaf1182c5c325109b5aba11cf60de
            Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5072293
            Auto-Submit: Andrew Walbran <qwandor@google.com>
            Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
            Reviewed-by: Frederick Mayle <fmayle@google.com>
            Commit-Queue: Frederick Mayle <fmayle@google.com>