[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/7] contrib/elf2dmp: Continue even contexts are lacking
From: |
Peter Maydell |
Subject: |
Re: [PATCH 6/7] contrib/elf2dmp: Continue even contexts are lacking |
Date: |
Mon, 4 Mar 2024 18:02:05 +0000 |
On Sun, 3 Mar 2024 at 10:52, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> Contexts of some CPUs may be lacking or corrupted due to premature boot,
> but the output may still contain valuable information of other CPUs and
> memory.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> contrib/elf2dmp/main.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
I think it would be worth having a brief comment explaining why
we don't make these memory read failures fatal errors, to
avoid somebody in future putting the error path back in again.
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH 3/7] contrib/elf2dmp: Ensure segment fits in file, (continued)
- [PATCH 3/7] contrib/elf2dmp: Ensure segment fits in file, Akihiko Odaki, 2024/03/03
- [PATCH 4/7] contrib/elf2dmp: Use lduw_le_p() to read PDB, Akihiko Odaki, 2024/03/03
- [PATCH 5/7] contrib/elf2dmp: Use rol64() to decode, Akihiko Odaki, 2024/03/03
- [PATCH 7/7] MAINTAINERS: Add Akihiko Odaki as a elf2dmp reviewer, Akihiko Odaki, 2024/03/03
- [PATCH 6/7] contrib/elf2dmp: Continue even contexts are lacking, Akihiko Odaki, 2024/03/03
- Re: [PATCH 6/7] contrib/elf2dmp: Continue even contexts are lacking,
Peter Maydell <=
- Re: [PATCH 0/7] contrib/elf2dmp: Improve robustness, Peter Maydell, 2024/03/04