Re: [PATCH 4/4] replay: simple auto-snapshot mode for record

[Nicholas Piggin]

On Wed Feb 28, 2024 at 3:07 PM AEST, Pavel Dovgalyuk wrote:
> On 26.02.2024 10:36, Nicholas Piggin wrote:
> >>> @@ -313,6 +317,27 @@ void replay_configure(QemuOpts *opts)
> >>>        }
> >>>    
> >>>        replay_snapshot = g_strdup(qemu_opt_get(opts, "rrsnapshot"));
> >>> +    if (replay_snapshot && mode == REPLAY_MODE_RECORD) {
> >>
> >> Can such a snapshotting may be useful in replay mode?
> > 
> > Does snapshotting do anything in replay mode? 
>
> Yes, you can create as many snapshots as you want if 'snapshot=on'
> option of the disk image was not used.

Actually something goes wrong and the machine crashes when I try
this, so it's not so simple. It's a nice idea to be able to do
because it really makes reverse debugging much faster, but no time
to look into it further at the moment.

So I will resubmit basically as is, which works for me nicely.
Tweaks can be made or other timer behaviour can be added later,
it's not a hard API with precisely defined semantics. So it would
be nice to get the basic mechanisms merged and tests added.

Thanks,
Nick