Re: [PATCH v2 00/10] mirror: allow switching from background to active mode

[Markus Armbruster]

Kevin Wolf <kwolf@redhat.com> writes:

> Am 28.02.2024 um 19:07 hat Vladimir Sementsov-Ogievskiy geschrieben:

[...]

>> About the APIs, I think, of course we should deprecate block-job-* API, 
>> because we already have jobs which are not block-jobs, so we can't deprecate 
>> job-* API.
>> 
>> So I suggest a plan:
>> 
>> 1. Add job-change command simply in block-core.json, as a simple copy
>>    of block-job-change, to not care with resolving inclusion loops.
>>    (ha we could simply name our block-job-change to be job-change and
>>    place it in block-core.json, but now is too late)
>> 
>> 2. Support changing speed in a new job-chage command. (or both in
>>    block-job-change and job-change, keeping them equal)
>
> It should be both block-job-change and job-change.
>
> Having job-change in block-core.json rather than job.json is ugly, but
> if Markus doesn't complain, why would I.

What we have is ugly and confusing: two interfaces with insufficient
guidance on which one to use.

Unifying the interfaces will reduce confusion immediately, and may
reduce ugliness eventually.

I take it.

[...]