[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 11/27] migration: Add mapped-ram URI compatibility check
From: |
peterx |
Subject: |
[PULL 11/27] migration: Add mapped-ram URI compatibility check |
Date: |
Mon, 4 Mar 2024 09:26:18 +0800 |
From: Fabiano Rosas <farosas@suse.de>
The mapped-ram migration format needs a channel that supports seeking
to be able to write each page to an arbitrary offset in the migration
stream.
Reviewed-by: "Daniel P. Berrangé" <berrange@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20240229153017.2221-9-farosas@suse.de
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/migration.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index 69f68f940d..2669600d25 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -148,10 +148,39 @@ static bool
transport_supports_multi_channels(MigrationAddress *addr)
return false;
}
+static bool migration_needs_seekable_channel(void)
+{
+ return migrate_mapped_ram();
+}
+
+static bool transport_supports_seeking(MigrationAddress *addr)
+{
+ if (addr->transport == MIGRATION_ADDRESS_TYPE_FILE) {
+ return true;
+ }
+
+ /*
+ * At this point, the user might not yet have passed the file
+ * descriptor to QEMU, so we cannot know for sure whether it
+ * refers to a plain file or a socket. Let it through anyway.
+ */
+ if (addr->transport == MIGRATION_ADDRESS_TYPE_SOCKET) {
+ return addr->u.socket.type == SOCKET_ADDRESS_TYPE_FD;
+ }
+
+ return false;
+}
+
static bool
migration_channels_and_transport_compatible(MigrationAddress *addr,
Error **errp)
{
+ if (migration_needs_seekable_channel() &&
+ !transport_supports_seeking(addr)) {
+ error_setg(errp, "Migration requires seekable transport (e.g. file)");
+ return false;
+ }
+
if (migration_needs_multiple_sockets() &&
!transport_supports_multi_channels(addr)) {
error_setg(errp, "Migration requires multi-channel URIs (e.g. tcp)");
--
2.44.0
- [PULL 00/27] Migration next patches, peterx, 2024/03/03
- [PULL 01/27] migration: massage cpr-reboot documentation, peterx, 2024/03/03
- [PULL 02/27] migration: Properly apply migration compression level parameters, peterx, 2024/03/03
- [PULL 04/27] migration/multifd: Cleanup multifd_recv_sync_main, peterx, 2024/03/03
- [PULL 05/27] io: add and implement QIO_CHANNEL_FEATURE_SEEKABLE for channel file, peterx, 2024/03/03
- [PULL 03/27] tests/migration: Set compression level in migration tests, peterx, 2024/03/03
- [PULL 07/27] io: implement io_pwritev/preadv for QIOChannelFile, peterx, 2024/03/03
- [PULL 08/27] io: fsync before closing a file channel, peterx, 2024/03/03
- [PULL 06/27] io: Add generic pwritev/preadv interface, peterx, 2024/03/03
- [PULL 10/27] migration/ram: Introduce 'mapped-ram' migration capability, peterx, 2024/03/03
- [PULL 11/27] migration: Add mapped-ram URI compatibility check,
peterx <=
- [PULL 09/27] migration/qemu-file: add utility methods for working with seekable channels, peterx, 2024/03/03
- [PULL 12/27] migration/ram: Add outgoing 'mapped-ram' migration, peterx, 2024/03/03
- [PULL 13/27] migration/ram: Add incoming 'mapped-ram' migration, peterx, 2024/03/03
- [PULL 14/27] tests/qtest/migration: Add tests for mapped-ram file-based migration, peterx, 2024/03/03
- [PULL 16/27] migration/multifd: Decouple recv method from pages, peterx, 2024/03/03
- [PULL 15/27] migration/multifd: Rename MultiFDSend|RecvParams::data to compress_data, peterx, 2024/03/03
- [PULL 21/27] migration/multifd: Add incoming QIOChannelFile support, peterx, 2024/03/03
- [PULL 18/27] migration/multifd: Allow receiving pages without packets, peterx, 2024/03/03
- [PULL 24/27] migration/multifd: Support incoming mapped-ram stream format, peterx, 2024/03/03
- [PULL 17/27] migration/multifd: Allow multifd without packets, peterx, 2024/03/03