Re: [PATCH v2 1/3] qtest: migration: Enhance qtest migration functions to support 'channels' argument

[Het Gala]

On 01/03/24 2:19 pm, Het Gala wrote:
> On 29/02/24 6:47 am, Fabiano Rosas wrote:
> > Het Gala <het.gala@nutanix.com> writes:
> >
> > > On 27/02/24 1:04 am, Het Gala wrote:
> > > > On 26/02/24 6:31 pm, Fabiano Rosas wrote:
> > > > > Het Gala<het.gala@nutanix.com>  writes:
> > > > >
> > > > > > On 24/02/24 1:42 am, Fabiano Rosas wrote:
> > > > > > this was the same first approach that I attempted. It won't work 
> > > > > > because
> > > > > >
> > > > > > The final 'migrate' QAPI with channels string would look like
[...]
> > I'm not sure what you tried. This works:
> >
> >      g_assert(!qdict_haskey(args, "channels"));
> >      if (channels) {
> >          channels_obj = qobject_from_json(channels, errp);
> >          qdict_put_obj(args, "channels", channels_obj);
> >      }
>
> Are you sure the above works ?

Sorry, please ignore the below doubt. I understood what silly mistakes I 
was doing. you were right, qobject_from_json() works fine and converts 
string to json object.

Will follow your latest reply and send out the patch really soon. Thank 
you for unblocking me here quickly :)

> [...]

Regards,

Het Gala