[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2] migration: export fewer options
From: |
Peter Xu |
Subject: |
Re: [PATCH V2] migration: export fewer options |
Date: |
Fri, 1 Mar 2024 15:47:53 +0800 |
On Thu, Feb 29, 2024 at 07:03:36AM +0100, Markus Armbruster wrote:
> Steven Sistare <steven.sistare@oracle.com> writes:
>
> > Just a reminder, after our further discussion in the V1 thread,
> > this patch is still what I propose, no updates needed.
> >
> > Markus, I think Peter is looking for your blessing on the new
> > file name: include/migration/client-options.h.
>
> Not my preference, but no objection.
There's yet one alternative, which is to put these exported option
functions into misc.h directly. After all that's not so much, and misc.h
already hold random stuff from elsewhere.
Steve, would you repost this patch (with/without my above comment taken)
along with your other series with a rebase to migration-next? It doesn't
apply there. Re the other series: one nitpick comment on the last patch,
where you may consider splitting the removal of the unused 2 functions into
a standalone patch. Other than that it looks good to me.
https://gitlab.com/peterx/qemu/-/tree/migration-next
Thanks,
--
Peter Xu
- Re: [PATCH V2] migration: export fewer options,
Peter Xu <=