[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/17] hw/scsi/vhost-scsi: Fix missing ERRP_GUARD() for error
From: |
Zhao Liu |
Subject: |
Re: [PATCH 04/17] hw/scsi/vhost-scsi: Fix missing ERRP_GUARD() for error_prepend() |
Date: |
Fri, 1 Mar 2024 14:42:03 +0800 |
> > @@ -220,6 +220,7 @@ static int vhost_scsi_set_workers(VHostSCSICommon *vsc,
> > bool per_virtqueue)
> > static void vhost_scsi_realize(DeviceState *dev, Error **errp)
> > {
> > + ERRP_GUARD();
> > VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(dev);
> > VHostSCSICommon *vsc = VHOST_SCSI_COMMON(dev);
> > Error *err = NULL;
>
> I think you could remove the "err" variable and the error_propagate stuff in
> here now.
>
OK, I'll. Thanks.
-Zhao
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 04/17] hw/scsi/vhost-scsi: Fix missing ERRP_GUARD() for error_prepend(),
Zhao Liu <=