[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] migration: re-format cpr-reboot documentation
From: |
Steven Sistare |
Subject: |
Re: [PATCH] migration: re-format cpr-reboot documentation |
Date: |
Thu, 29 Feb 2024 09:49:56 -0500 |
User-agent: |
Mozilla Thunderbird |
Please ignore this, I will send a V2 that incorporates additional comments from
Markus that I missed in my inbox.
- Steve
On 2/29/2024 9:15 AM, Steve Sistare wrote:
> Re-wrap the cpr-reboot documentation to 70 columns, use '@' for
> cpr-reboot references, and capitalize COLO.
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
> ---
> qapi/migration.json | 36 +++++++++++++++++++-----------------
> 1 file changed, 19 insertions(+), 17 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index c6bfe2e..b69f62a 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -636,28 +636,30 @@
> #
> # @normal: the original form of migration. (since 8.2)
> #
> -# @cpr-reboot: The migrate command stops the VM and saves state to the URI.
> -# After quitting qemu, the user resumes by running qemu -incoming.
> +# @cpr-reboot: The migrate command stops the VM and saves state to
> +# the URI. After quitting qemu, the user resumes by running
> +# qemu -incoming.
> #
> -# This mode allows the user to quit qemu, and restart an updated version
> -# of qemu. The user may even update and reboot the OS before restarting,
> -# as long as the URI persists across a reboot.
> +# This mode allows the user to quit qemu and restart an updated
> +# version of qemu. The user may even update and reboot the OS
> +# before restarting, as long as the URI persists across a reboot.
> #
> -# Unlike normal mode, the use of certain local storage options does not
> -# block the migration, but the user must not modify guest block devices
> -# between the quit and restart.
> +# Unlike normal mode, the use of certain local storage options
> +# does not block the migration, but the user must not modify guest
> +# block devices between the quit and restart.
> #
> -# This mode supports vfio devices provided the user first puts the guest
> -# in the suspended runstate, such as by issuing guest-suspend-ram to the
> -# qemu guest agent.
> +# This mode supports vfio devices provided the user first puts
> +# the guest in the suspended runstate, such as by issuing
> +# guest-suspend-ram to the qemu guest agent.
> #
> -# Best performance is achieved when the memory backend is shared and the
> -# @x-ignore-shared migration capability is set, but this is not required.
> -# Further, if the user reboots before restarting such a configuration,
> the
> -# shared backend must be be non-volatile across reboot, such as by
> backing
> -# it with a dax device.
> +# Best performance is achieved when the memory backend is shared
> +# and the @x-ignore-shared migration capability is set, but this
> +# is not required. Further, if the user reboots before restarting
> +# such a configuration, the shared backend must be be non-volatile
> +# across reboot, such as by backing it with a dax device.
> #
> -# cpr-reboot may not be used with postcopy, colo, or background-snapshot.
> +# @cpr-reboot may not be used with postcopy, background-snapshot,
> +# or COLO.
> #
> # (since 8.2)
> ##