[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[QEMU][PATCH v3 4/7] xen: let xen_ram_addr_from_mapcache() return -1 in
From: |
Vikram Garhwal |
Subject: |
[QEMU][PATCH v3 4/7] xen: let xen_ram_addr_from_mapcache() return -1 in case of not found entry |
Date: |
Tue, 27 Feb 2024 14:34:58 -0800 |
From: Juergen Gross <jgross@suse.com>
Today xen_ram_addr_from_mapcache() will either abort() or return 0 in
case it can't find a matching entry for a pointer value. Both cases
are bad, so change that to return an invalid address instead.
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
hw/xen/xen-mapcache.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/xen/xen-mapcache.c b/hw/xen/xen-mapcache.c
index dfc412d138..179b7e95b2 100644
--- a/hw/xen/xen-mapcache.c
+++ b/hw/xen/xen-mapcache.c
@@ -396,13 +396,8 @@ ram_addr_t xen_ram_addr_from_mapcache(void *ptr)
}
}
if (!found) {
- trace_xen_ram_addr_from_mapcache_not_found(ptr);
- QTAILQ_FOREACH(reventry, &mapcache->locked_entries, next) {
- trace_xen_ram_addr_from_mapcache_found(reventry->paddr_index,
- reventry->vaddr_req);
- }
- abort();
- return 0;
+ mapcache_unlock();
+ return RAM_ADDR_INVALID;
}
entry = &mapcache->entry[paddr_index % mapcache->nr_buckets];
@@ -411,7 +406,7 @@ ram_addr_t xen_ram_addr_from_mapcache(void *ptr)
}
if (!entry) {
trace_xen_ram_addr_from_mapcache_not_in_cache(ptr);
- raddr = 0;
+ raddr = RAM_ADDR_INVALID;
} else {
raddr = (reventry->paddr_index << MCACHE_BUCKET_SHIFT) +
((unsigned long) ptr - (unsigned long) entry->vaddr_base);
--
2.17.1
- [QEMU][PATCH v3 0/7] Xen: support grant mappings., Vikram Garhwal, 2024/02/27
- [QEMU][PATCH v3 1/7] softmmu: physmem: Split ram_block_add(), Vikram Garhwal, 2024/02/27
- [QEMU][PATCH v3 2/7] xen: add pseudo RAM region for grant mappings, Vikram Garhwal, 2024/02/27
- [QEMU][PATCH v3 3/7] softmmu: let qemu_map_ram_ptr() use qemu_ram_ptr_length(), Vikram Garhwal, 2024/02/27
- [QEMU][PATCH v3 4/7] xen: let xen_ram_addr_from_mapcache() return -1 in case of not found entry,
Vikram Garhwal <=
- [QEMU][PATCH v3 6/7] xen: add map and unmap callbacks for grant region, Vikram Garhwal, 2024/02/27
- [QEMU][PATCH v3 5/7] memory: add MemoryRegion map and unmap callbacks, Vikram Garhwal, 2024/02/27
- [QEMU][PATCH v3 7/7] hw: arm: Add grant mapping., Vikram Garhwal, 2024/02/27
- Re: [QEMU][PATCH v3 0/7] Xen: support grant mappings., Manos Pitsidianakis, 2024/02/28