qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/9] Hexagon (target/hexagon) Mark dest_idx in trans function


From: Matheus Tavares Bernardino
Subject: Re: [PATCH 3/9] Hexagon (target/hexagon) Mark dest_idx in trans functions
Date: Tue, 27 Feb 2024 11:20:48 -0300

On Mon, 26 Feb 2024 13:17:16 -0700 Taylor Simpson <ltaylorsimpson@gmail.com> 
wrote:
>
> diff --git a/target/hexagon/gen_trans_funcs.py 
> b/target/hexagon/gen_trans_funcs.py
> index 79475b2946..07292e0170 100755
> --- a/target/hexagon/gen_trans_funcs.py
> +++ b/target/hexagon/gen_trans_funcs.py
> @@ -85,6 +85,7 @@ def gen_trans_funcs(f):
>          """))
>  
>          new_read_idx = -1
> +        dest_idx = -1
>          for regno, regstruct in enumerate(regs):
>              reg_type, reg_id, _, _ = regstruct
>              reg = hex_common.get_register(tag, reg_type, reg_id)
> @@ -93,6 +94,8 @@ def gen_trans_funcs(f):
>              """))
>              if reg.is_read() and reg.is_new():
>                  new_read_idx = regno
> +            if reg.is_written() and dest_idx == -1:
> +                dest_idx = regno

I was first wondering what should we do when "reg.is_written()" and
"dest_idx != -1". But then I remembered we previously used strchr(), so we
would stop at the first match anyways.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]