qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 7/7] hw/intc: Check @errp to handle the error of IOAPICCom


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 7/7] hw/intc: Check @errp to handle the error of IOAPICCommonClass.realize()
Date: Fri, 23 Feb 2024 18:52:26 +0100
User-agent: Mozilla Thunderbird

On 23/2/24 09:56, Zhao Liu wrote:
From: Zhao Liu <zhao1.liu@intel.com>

IOAPICCommonClass implements its own private realize(), and this private
realize() allows error.

Since IOAPICCommonClass.realize() returns void, to check the error,
dereference @errp with ERRP_GUARD().

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
v2:
  * Add the missing ERRP_GUARD(). (Markus)
  * Move this single patch into @errp fixing series. (Micheal)
---
  hw/intc/ioapic_common.c | 4 ++++
  1 file changed, 4 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]