Re: [PATCH v3 1/3] hw/i2c: Implement Broadcom Serial Controller (BSC)

[Peter Maydell]

On Tue, 20 Feb 2024 at 13:42, Rayhan Faizel <rayhan.faizel@gmail.com> wrote:
>
> A few deficiencies in the current device model need to be noted.
>
> 1. FIFOs are not used. All sends and receives are done directly.
> 2. Repeated starts are not emulated. Repeated starts can be triggered in real
> hardware by sending a new read transfer request in the window time between
> transfer active set of write transfer request and done bit set of the same.
>
> Signed-off-by: Rayhan Faizel <rayhan.faizel@gmail.com>

Other than the minor things Philippe has noted,

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM