[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [External] Re: [PATCH v2 3/7] migration/multifd: Zero page transmiss
From: |
Hao Xiang |
Subject: |
Re: [External] Re: [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread. |
Date: |
Thu, 22 Feb 2024 20:38:35 -0800 |
On Fri, Feb 16, 2024 at 9:08 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 2/16/24 12:39, Hao Xiang wrote:
> > +void multifd_zero_page_check_recv(MultiFDRecvParams *p)
> > +{
> > + for (int i = 0; i < p->zero_num; i++) {
> > + void *page = p->host + p->zero[i];
> > + if (!buffer_is_zero(page, p->page_size)) {
> > + memset(page, 0, p->page_size);
> > + }
> > + }
> > +}
>
> You should not check the buffer is zero here, you should just zero it.
I will fix it in the next version.
>
>
> r~
- Re: [PATCH v2 1/7] migration/multifd: Add new migration option zero-page-detection., (continued)
- [PATCH v2 2/7] migration/multifd: Support for zero pages transmission in multifd format., Hao Xiang, 2024/02/16
- [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread., Hao Xiang, 2024/02/16
- Re: [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread., Markus Armbruster, 2024/02/21
- Re: [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread., Elena Ufimtseva, 2024/02/21
- Re: [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread., Fabiano Rosas, 2024/02/21
- Re: [External] Re: [PATCH v2 3/7] migration/multifd: Zero page transmission on the multifd thread., Hao Xiang, 2024/02/23