[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH V4 02/14] migration: remove error from notifier data
From: |
Steve Sistare |
Subject: |
[PATCH V4 02/14] migration: remove error from notifier data |
Date: |
Thu, 22 Feb 2024 09:28:28 -0800 |
Remove the error object from opaque data passed to notifiers.
Use the new error parameter passed to the notifier instead.
Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
hw/virtio/vhost-user.c | 8 ++++----
include/migration/misc.h | 1 -
migration/postcopy-ram.c | 1 -
migration/postcopy-ram.h | 1 -
migration/ram.c | 1 -
5 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index f502345..a1eea85 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -2096,20 +2096,20 @@ static int
vhost_user_postcopy_notifier(NotifierWithReturn *notifier,
if (!virtio_has_feature(dev->protocol_features,
VHOST_USER_PROTOCOL_F_PAGEFAULT)) {
/* TODO: Get the device name into this error somehow */
- error_setg(pnd->errp,
+ error_setg(errp,
"vhost-user backend not capable of postcopy");
return -ENOENT;
}
break;
case POSTCOPY_NOTIFY_INBOUND_ADVISE:
- return vhost_user_postcopy_advise(dev, pnd->errp);
+ return vhost_user_postcopy_advise(dev, errp);
case POSTCOPY_NOTIFY_INBOUND_LISTEN:
- return vhost_user_postcopy_listen(dev, pnd->errp);
+ return vhost_user_postcopy_listen(dev, errp);
case POSTCOPY_NOTIFY_INBOUND_END:
- return vhost_user_postcopy_end(dev, pnd->errp);
+ return vhost_user_postcopy_end(dev, errp);
default:
/* We ignore notifications we don't know */
diff --git a/include/migration/misc.h b/include/migration/misc.h
index 1bc8902..5e65c18 100644
--- a/include/migration/misc.h
+++ b/include/migration/misc.h
@@ -31,7 +31,6 @@ typedef enum PrecopyNotifyReason {
typedef struct PrecopyNotifyData {
enum PrecopyNotifyReason reason;
- Error **errp;
} PrecopyNotifyData;
void precopy_infrastructure_init(void);
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index 3ab2f6b..0273dc6 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -77,7 +77,6 @@ int postcopy_notify(enum PostcopyNotifyReason reason, Error
**errp)
{
struct PostcopyNotifyData pnd;
pnd.reason = reason;
- pnd.errp = errp;
return notifier_with_return_list_notify(&postcopy_notifier_list,
&pnd, errp);
diff --git a/migration/postcopy-ram.h b/migration/postcopy-ram.h
index 442ab89..ecae941 100644
--- a/migration/postcopy-ram.h
+++ b/migration/postcopy-ram.h
@@ -128,7 +128,6 @@ enum PostcopyNotifyReason {
struct PostcopyNotifyData {
enum PostcopyNotifyReason reason;
- Error **errp;
};
void postcopy_add_notifier(NotifierWithReturn *nn);
diff --git a/migration/ram.c b/migration/ram.c
index 5b6b09e..45a00b4 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -426,7 +426,6 @@ int precopy_notify(PrecopyNotifyReason reason, Error **errp)
{
PrecopyNotifyData pnd;
pnd.reason = reason;
- pnd.errp = errp;
return notifier_with_return_list_notify(&precopy_notifier_list, &pnd,
errp);
}
--
1.8.3.1
- [PATCH V4 00/14] allow cpr-reboot for vfio, Steve Sistare, 2024/02/22
- [PATCH V4 02/14] migration: remove error from notifier data,
Steve Sistare <=
- [PATCH V4 01/14] notify: pass error to notifier with return, Steve Sistare, 2024/02/22
- [PATCH V4 03/14] migration: convert to NotifierWithReturn, Steve Sistare, 2024/02/22
- [PATCH V4 04/14] migration: MigrationEvent for notifiers, Steve Sistare, 2024/02/22
- [PATCH V4 05/14] migration: remove postcopy_after_devices, Steve Sistare, 2024/02/22
- [PATCH V4 07/14] migration: per-mode notifiers, Steve Sistare, 2024/02/22
- [PATCH V4 08/14] migration: refactor migrate_fd_connect failures, Steve Sistare, 2024/02/22
- [PATCH V4 09/14] migration: notifier error checking, Steve Sistare, 2024/02/22
- [PATCH V4 11/14] vfio: register container for cpr, Steve Sistare, 2024/02/22