[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 19/32] hw/i386/pc_sysfw: Use qdev_is_realized() instead of QOM API
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 19/32] hw/i386/pc_sysfw: Use qdev_is_realized() instead of QOM API |
Date: |
Thu, 22 Feb 2024 13:55:12 +0100 |
Prefer QDev API for QDev objects, avoid the underlying QOM layer.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Message-Id: <20240216110313.17039-3-philmd@linaro.org>
---
hw/i386/pc_sysfw.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c
index 2dcaa116ad..b02e285579 100644
--- a/hw/i386/pc_sysfw.c
+++ b/hw/i386/pc_sysfw.c
@@ -95,17 +95,15 @@ static void pc_system_flash_cleanup_unused(PCMachineState
*pcms)
{
char *prop_name;
int i;
- Object *dev_obj;
assert(PC_MACHINE_GET_CLASS(pcms)->pci_enabled);
for (i = 0; i < ARRAY_SIZE(pcms->flash); i++) {
- dev_obj = OBJECT(pcms->flash[i]);
- if (!object_property_get_bool(dev_obj, "realized", &error_abort)) {
+ if (!qdev_is_realized(DEVICE(pcms->flash[i]))) {
prop_name = g_strdup_printf("pflash%d", i);
object_property_del(OBJECT(pcms), prop_name);
g_free(prop_name);
- object_unparent(dev_obj);
+ object_unparent(OBJECT(pcms->flash[i]));
pcms->flash[i] = NULL;
}
}
--
2.41.0
- [PULL 02/32] hw/sysbus: Inline and remove sysbus_add_io(), Philippe Mathieu-Daudé, 2024/02/22
- [PULL 08/32] hw/ppc/pnv_bmc: Use qdev_new() instead of QOM API, Philippe Mathieu-Daudé, 2024/02/22
- [PULL 07/32] hw/ppc/spapr_cpu: Use qdev_is_realized() instead of QOM API, Philippe Mathieu-Daudé, 2024/02/22
- [PULL 09/32] hw/tricore/testboard: Use qdev_new() instead of QOM basic API, Philippe Mathieu-Daudé, 2024/02/22
- [PULL 19/32] hw/i386/pc_sysfw: Use qdev_is_realized() instead of QOM API,
Philippe Mathieu-Daudé <=
- [PULL 22/32] hw/acpi: Include missing 'qapi/qapi-types-acpi.h' generated header, Philippe Mathieu-Daudé, 2024/02/22
- [PULL 23/32] hw/acpi/cpu: Use CPUState typedef, Philippe Mathieu-Daudé, 2024/02/22
- [PULL 24/32] hw/acpi/ich9_tco: Include missing 'migration/vmstate.h' header, Philippe Mathieu-Daudé, 2024/02/22
- [PULL 32/32] hw/sparc/leon3: Fix wrong usage of DO_UPCAST macro, Philippe Mathieu-Daudé, 2024/02/22
- [PULL v2 00/32] Misc HW patches for 2024-02-22, Philippe Mathieu-Daudé, 2024/02/22