[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 3/5] migration/multifd: Make multifd_channel_connect() return
From: |
peterx |
Subject: |
[PATCH v2 3/5] migration/multifd: Make multifd_channel_connect() return void |
Date: |
Thu, 22 Feb 2024 17:52:59 +0800 |
From: Peter Xu <peterx@redhat.com>
It never fails, drop the retval and also the Error**.
Suggested-by: Avihai Horon <avihaih@nvidia.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/multifd.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index da2e7c1db1..f52f01ca85 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -925,9 +925,7 @@ static bool multifd_tls_channel_connect(MultiFDSendParams
*p,
return true;
}
-static bool multifd_channel_connect(MultiFDSendParams *p,
- QIOChannel *ioc,
- Error **errp)
+static void multifd_channel_connect(MultiFDSendParams *p, QIOChannel *ioc)
{
qio_channel_set_delay(ioc, false);
@@ -938,7 +936,6 @@ static bool multifd_channel_connect(MultiFDSendParams *p,
p->thread_created = true;
qemu_thread_create(&p->thread, p->name, multifd_send_thread, p,
QEMU_THREAD_JOINABLE);
- return true;
}
/*
@@ -970,7 +967,8 @@ static void multifd_new_send_channel_async(QIOTask *task,
gpointer opaque)
return;
}
} else {
- ret = multifd_channel_connect(p, ioc, &local_err);
+ multifd_channel_connect(p, ioc);
+ ret = true;
}
out:
--
2.43.0
- [PATCH v2 0/5] migration: cleanup TLS channel referencing, peterx, 2024/02/22
- [PATCH v2 1/5] migration/multifd: Cleanup TLS iochannel referencing, peterx, 2024/02/22
- [PATCH v2 2/5] migration/multifd: Drop registered_yank, peterx, 2024/02/22
- [PATCH v2 3/5] migration/multifd: Make multifd_channel_connect() return void,
peterx <=
- [PATCH v2 4/5] migration/multifd: Cleanup outgoing_args in state destroy, peterx, 2024/02/22
- [PATCH v2 5/5] migration/multifd: Drop unnecessary helper to destroy IOC, peterx, 2024/02/22
- Re: [PATCH v2 0/5] migration: cleanup TLS channel referencing, Peter Xu, 2024/02/25