qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/16] tests/qapi-schema: Cover duplicate 'Features:' line


From: Daniel P . Berrangé
Subject: Re: [PATCH 02/16] tests/qapi-schema: Cover duplicate 'Features:' line
Date: Tue, 20 Feb 2024 15:12:07 +0000
User-agent: Mutt/2.2.12 (2023-09-09)

On Fri, Feb 16, 2024 at 03:58:26PM +0100, Markus Armbruster wrote:
> We don't actually recognize the second 'Features:' line.  Instead, we
> treat it as an untagged section.
> 
> If it was followed by feature description, we'd reject that like
> "description of '@feat2:' follows a section".  Less than clear.
> 
> To be improved shortly.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  tests/qapi-schema/doc-duplicate-features.err  |  0
>  tests/qapi-schema/doc-duplicate-features.json | 11 ++++++++++
>  tests/qapi-schema/doc-duplicate-features.out  | 22 +++++++++++++++++++
>  tests/qapi-schema/meson.build                 |  1 +
>  4 files changed, 34 insertions(+)
>  create mode 100644 tests/qapi-schema/doc-duplicate-features.err
>  create mode 100644 tests/qapi-schema/doc-duplicate-features.json
>  create mode 100644 tests/qapi-schema/doc-duplicate-features.out

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




reply via email to

[Prev in Thread] Current Thread [Next in Thread]