[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/16] tests/qapi-schema: Cover duplicate 'Features:' line
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 02/16] tests/qapi-schema: Cover duplicate 'Features:' line |
Date: |
Tue, 20 Feb 2024 15:12:07 +0000 |
User-agent: |
Mutt/2.2.12 (2023-09-09) |
On Fri, Feb 16, 2024 at 03:58:26PM +0100, Markus Armbruster wrote:
> We don't actually recognize the second 'Features:' line. Instead, we
> treat it as an untagged section.
>
> If it was followed by feature description, we'd reject that like
> "description of '@feat2:' follows a section". Less than clear.
>
> To be improved shortly.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/qapi-schema/doc-duplicate-features.err | 0
> tests/qapi-schema/doc-duplicate-features.json | 11 ++++++++++
> tests/qapi-schema/doc-duplicate-features.out | 22 +++++++++++++++++++
> tests/qapi-schema/meson.build | 1 +
> 4 files changed, 34 insertions(+)
> create mode 100644 tests/qapi-schema/doc-duplicate-features.err
> create mode 100644 tests/qapi-schema/doc-duplicate-features.json
> create mode 100644 tests/qapi-schema/doc-duplicate-features.out
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 13/16] qapi: Merge adjacent untagged sections, (continued)
- [PATCH 16/16] qapi: Divorce QAPIDoc from QAPIParseError, Markus Armbruster, 2024/02/16
- [PATCH 03/16] tests/qapi-schema: Cover 'Features:' not followed by descriptions, Markus Armbruster, 2024/02/16
- [PATCH 15/16] qapi: Reject multiple and empty feature descriptions, Markus Armbruster, 2024/02/16
- [PATCH 08/16] qapi: Rename QAPIDoc.Section.name to .tag, Markus Armbruster, 2024/02/16
- [PATCH 02/16] tests/qapi-schema: Cover duplicate 'Features:' line, Markus Armbruster, 2024/02/16
- Re: [PATCH 02/16] tests/qapi-schema: Cover duplicate 'Features:' line,
Daniel P . Berrangé <=
- [PATCH 12/16] qapi: Call QAPIDoc.check() always, Markus Armbruster, 2024/02/16
- [PATCH 14/16] qapi: Rewrite doc comment parser, Markus Armbruster, 2024/02/16
- [PATCH 10/16] qapi: Require descriptions and tagged sections to be indented, Markus Armbruster, 2024/02/16