[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/17] i386/cpu: Mask with XCR0/XSS mask for FEAT_XSAVE_XCR0_HI an
From: |
Paolo Bonzini |
Subject: |
[PULL 02/17] i386/cpu: Mask with XCR0/XSS mask for FEAT_XSAVE_XCR0_HI and FEAT_XSAVE_XSS_HI leafs |
Date: |
Tue, 20 Feb 2024 09:05:43 +0100 |
From: Xiaoyao Li <xiaoyao.li@intel.com>
The value of FEAT_XSAVE_XCR0_HI leaf and FEAT_XSAVE_XSS_HI leaf also
need to be masked by XCR0 and XSS mask respectively, to make it
logically correct.
Fixes: 301e90675c3f ("target/i386: Enable support for XSAVES based features")
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
Reviewed-by: Yang Weijiang <weijiang.yang@intel.com>
Message-ID: <20240115091325.1904229-3-xiaoyao.li@intel.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/cpu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 800caeb593b..3ce138fecb7 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -6947,9 +6947,9 @@ static void x86_cpu_enable_xsave_components(X86CPU *cpu)
}
env->features[FEAT_XSAVE_XCR0_LO] = mask & CPUID_XSTATE_XCR0_MASK;
- env->features[FEAT_XSAVE_XCR0_HI] = mask >> 32;
+ env->features[FEAT_XSAVE_XCR0_HI] = (mask & CPUID_XSTATE_XCR0_MASK) >> 32;
env->features[FEAT_XSAVE_XSS_LO] = mask & CPUID_XSTATE_XSS_MASK;
- env->features[FEAT_XSAVE_XSS_HI] = mask >> 32;
+ env->features[FEAT_XSAVE_XSS_HI] = (mask & CPUID_XSTATE_XSS_MASK) >> 32;
}
/***** Steps involved on loading and filtering CPUID data
--
2.43.0
- [PULL 00/17] Build, x86 patches for 2024-02-16, Paolo Bonzini, 2024/02/20
- [PULL 01/17] i386/cpu: Clear FEAT_XSAVE_XSS_LO/HI leafs when CPUID_EXT_XSAVE is not available, Paolo Bonzini, 2024/02/20
- [PULL 02/17] i386/cpu: Mask with XCR0/XSS mask for FEAT_XSAVE_XCR0_HI and FEAT_XSAVE_XSS_HI leafs,
Paolo Bonzini <=
- [PULL 03/17] target/i386: Add support of KVM_FEATURE_ASYNC_PF_VMEXIT for guest, Paolo Bonzini, 2024/02/20
- [PULL 04/17] i386/pc: Drop pc_machine_kvm_type(), Paolo Bonzini, 2024/02/20
- [PULL 05/17] physmem: replace function name with __func__ in ram_block_discard_range(), Paolo Bonzini, 2024/02/20
- [PULL 06/17] i386/cpuid: Decrease cpuid_i when skipping CPUID leaf 1F, Paolo Bonzini, 2024/02/20
- [PULL 08/17] i386/cpuid: Move leaf 7 to correct group, Paolo Bonzini, 2024/02/20
- [PULL 09/17] mips: remove unnecessary "select PTIMER", Paolo Bonzini, 2024/02/20
- [PULL 10/17] isa-superio: validate floppy.count value, Paolo Bonzini, 2024/02/20
- [PULL 11/17] smc37c669: remove useless is_enabled functions, Paolo Bonzini, 2024/02/20
- [PULL 12/17] configure: do not create legacy symlinks, Paolo Bonzini, 2024/02/20
- [PULL 14/17] i386: xen: fix compilation --without-default-devices, Paolo Bonzini, 2024/02/20