qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 16/18] plugins: remove non per_vcpu inline operation from


From: Pierrick Bouvier
Subject: Re: [PATCH v4 16/18] plugins: remove non per_vcpu inline operation from API
Date: Wed, 14 Feb 2024 13:56:19 +0400
User-agent: Mozilla Thunderbird

On 2/13/24 22:44, Richard Henderson wrote:
On 2/12/24 23:40, Pierrick Bouvier wrote:
Now we have a thread-safe equivalent of inline operation, and that all
plugins were changed to use it, there is no point to keep the old API.

In more, it will help when we implement more functionality (conditional
callbacks), as we can assume that we operate on a scoreboard.

Bump API version as it's a breaking change for existing plugins.
Bump min API version too, as we removed some functions.

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
   include/qemu/qemu-plugin.h   | 58 ++++--------------------------------
   plugins/plugin.h             |  2 +-
   plugins/api.c                | 29 ------------------
   plugins/qemu-plugins.symbols |  3 --
   4 files changed, 6 insertions(+), 86 deletions(-)

diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
index cdf1266d724..9b11098ff82 100644
--- a/include/qemu/qemu-plugin.h
+++ b/include/qemu/qemu-plugin.h
@@ -53,11 +53,15 @@ typedef uint64_t qemu_plugin_id_t;
    * symbol qemu_plugin_version which can be checked.
    *
    * version 2: removed qemu_plugin_n_vcpus and qemu_plugin_n_max_vcpus
+ * version 3:
+ * Remove qemu_plugin_register_vcpu_{tb, insn, mem}_exec_inline.
+ * Those functions are replaced by *_per_vcpu variants, which guarantees
+ * thread-safety for operations.

You don't need to bump again, as we won't have a release in the middle of your 
patch set.

I'll bump this once. Discussing with Alex, only release points are important. Users tracking master are expected to detect and fix this.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]