Re: [PATCH v3 29/33] linux-user: Allow TARGET_PAGE_BITS_VARY

[Richard Henderson]

On 1/30/24 03:47, Ilya Leoshkevich wrote:
> I wonder if it would make sense to add something like the following to
> this patch?
>
> --- a/page-vary-target.c
> +++ b/page-vary-target.c
> @@ -26,8 +26,7 @@
>   bool set_preferred_target_page_bits(int bits)
>   {
>   #ifdef TARGET_PAGE_BITS_VARY
> -    assert(bits >= TARGET_PAGE_BITS_MIN);
> -    return set_preferred_target_page_bits_common(bits);
> +    return set_preferred_target_page_bits_common(MAX(TARGET_PAGE_BITS_MIN, 
> bits));
>   #else
>       return true;
>   #endif

No, this conflicts with the system-mode usage.
If we want to bound, then we need this MAX in the user-only caller.


r~