[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFCv2 6/8] backends/iommufd: Add ability to disable hugepages
|
From: |
Joao Martins |
|
Subject: |
Re: [PATCH RFCv2 6/8] backends/iommufd: Add ability to disable hugepages |
|
Date: |
Mon, 12 Feb 2024 19:16:47 +0000 |
On 12/02/2024 17:17, Markus Armbruster wrote:
> Joao Martins <joao.m.martins@oracle.com> writes:
>
>> Allow disabling hugepages to be dirty track at base page
>> granularity in similar vein to vfio_type1_iommu.disable_hugepages
>> but per IOAS.
>>
>> Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
>
> [...]
>
>> diff --git a/qapi/qom.json b/qapi/qom.json
>> index 84af23fe245d..9ad27e2b939b 100644
>> --- a/qapi/qom.json
>> +++ b/qapi/qom.json
>> @@ -809,7 +809,7 @@
>> # Since: 9.0
>> ##
>> { 'struct': 'IOMMUFDProperties',
>> - 'data': { '*fd': 'str' } }
>> + 'data': { '*fd': 'str', '*hugepages': 'bool' } }
>>
>> ##
>> # @RngProperties:
>
> Missing documentation for the new member.
>
> The latest QAPI PR is making this a hard error.
>
Gah, sorry. I think I didn't have that PR yet as I didn't hit any build errors.
Missing the doc was pure distraction.
Will fix it for the next version.
Joao
- Re: [PATCH RFCv2 4/8] vfio/iommufd: Implement VFIOIOMMUClass::set_dirty_tracking support, (continued)
[PATCH RFCv2 8/8] vfio/common: Allow disabling device dirty page tracking, Joao Martins, 2024/02/12
[PATCH RFCv2 6/8] backends/iommufd: Add ability to disable hugepages, Joao Martins, 2024/02/12
[PATCH RFCv2 7/8] vfio/migration: Don't block migration device dirty tracking is unsupported, Joao Martins, 2024/02/12
Re: [PATCH RFCv2 0/8] vfio/iommufd: IOMMUFD Dirty Tracking, Joao Martins, 2024/02/13