[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 3/7] vfio: Avoid inspecting option QDict for rombar
From: |
Akihiko Odaki |
Subject: |
[PATCH v3 3/7] vfio: Avoid inspecting option QDict for rombar |
Date: |
Mon, 12 Feb 2024 19:20:31 +0900 |
Use pci_rom_bar_explicitly_enabled() to determine if rombar is explicitly
enabled.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
hw/vfio/pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index d7fe06715c4b..44178ac9355f 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -1010,7 +1010,6 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev)
{
uint32_t orig, size = cpu_to_le32((uint32_t)PCI_ROM_ADDRESS_MASK);
off_t offset = vdev->config_offset + PCI_ROM_ADDRESS;
- DeviceState *dev = DEVICE(vdev);
char *name;
int fd = vdev->vbasedev.fd;
@@ -1044,7 +1043,7 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev)
}
if (vfio_opt_rom_in_denylist(vdev)) {
- if (dev->opts && qdict_haskey(dev->opts, "rombar")) {
+ if (pci_rom_bar_explicitly_enabled(&vdev->pdev)) {
warn_report("Device at %s is known to cause system instability"
" issues during option rom execution",
vdev->vbasedev.name);
--
2.43.0
- [PATCH v3 0/7] hw/pci: SR-IOV related fixes and improvements, Akihiko Odaki, 2024/02/12
- [PATCH v3 1/7] hw/pci: Use -1 as a default value for rombar, Akihiko Odaki, 2024/02/12
- [PATCH v3 2/7] hw/pci: Determine if rombar is explicitly enabled, Akihiko Odaki, 2024/02/12
- [PATCH v3 3/7] vfio: Avoid inspecting option QDict for rombar,
Akihiko Odaki <=
- [PATCH v3 4/7] hw/qdev: Remove opts member, Akihiko Odaki, 2024/02/12
- [PATCH v3 5/7] pcie_sriov: Validate NumVFs, Akihiko Odaki, 2024/02/12
- [PATCH v3 6/7] pcie_sriov: Reuse SR-IOV VF device instances, Akihiko Odaki, 2024/02/12
- [PATCH v3 7/7] pcie_sriov: Release VFs failed to realize, Akihiko Odaki, 2024/02/12
- Message not available