[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 43/61] hw/riscv/virt-acpi-build.c: fix leak in build_rhct()
|
From: |
Alistair Francis |
|
Subject: |
[PULL 43/61] hw/riscv/virt-acpi-build.c: fix leak in build_rhct() |
|
Date: |
Fri, 9 Feb 2024 20:57:55 +1000 |
From: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
The 'isa' char pointer isn't being freed after use.
Issue detected by Valgrind:
==38752== 128 bytes in 1 blocks are definitely lost in loss record 3,190 of
3,884
==38752== at 0x484280F: malloc (vg_replace_malloc.c:442)
==38752== by 0x5189619: g_malloc (gmem.c:130)
==38752== by 0x51A5BF2: g_strconcat (gstrfuncs.c:628)
==38752== by 0x6C1E3E: riscv_isa_string_ext (cpu.c:2321)
==38752== by 0x6C1E3E: riscv_isa_string (cpu.c:2343)
==38752== by 0x6BD2EA: build_rhct (virt-acpi-build.c:232)
==38752== by 0x6BD2EA: virt_acpi_build (virt-acpi-build.c:556)
==38752== by 0x6BDC86: virt_acpi_setup (virt-acpi-build.c:662)
==38752== by 0x9C8DC6: notifier_list_notify (notify.c:39)
==38752== by 0x4A595A: qdev_machine_creation_done (machine.c:1589)
==38752== by 0x61E052: qemu_machine_creation_done (vl.c:2680)
==38752== by 0x61E052: qmp_x_exit_preconfig.part.0 (vl.c:2709)
==38752== by 0x6220C6: qmp_x_exit_preconfig (vl.c:2702)
==38752== by 0x6220C6: qemu_init (vl.c:3758)
==38752== by 0x425858: main (main.c:47)
Fixes: ebfd392893 ("hw/riscv/virt: virt-acpi-build.c: Add RHCT Table")
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-ID: <20240122221529.86562-2-dbarboza@ventanamicro.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
hw/riscv/virt-acpi-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/riscv/virt-acpi-build.c b/hw/riscv/virt-acpi-build.c
index 26c7e4482d..fb8baf64f6 100644
--- a/hw/riscv/virt-acpi-build.c
+++ b/hw/riscv/virt-acpi-build.c
@@ -196,7 +196,7 @@ static void build_rhct(GArray *table_data,
RISCVCPU *cpu = &s->soc[0].harts[0];
uint32_t mmu_offset = 0;
uint8_t satp_mode_max;
- char *isa;
+ g_autofree char *isa = NULL;
AcpiTable table = { .sig = "RHCT", .rev = 1, .oem_id = s->oem_id,
.oem_table_id = s->oem_table_id };
--
2.43.0
- [PULL 55/61] smbios: add processor-family option, (continued)
- [PULL 55/61] smbios: add processor-family option, Alistair Francis, 2024/02/09
- [PULL 59/61] target/riscv: Enable xtheadsync under user mode, Alistair Francis, 2024/02/09
- [PULL 61/61] target/riscv: add rv32i, rv32e and rv64e CPUs, Alistair Francis, 2024/02/09
- [PULL 40/61] target/riscv: Validate misa_mxl_max only once, Alistair Francis, 2024/02/09
- [PULL 42/61] target/riscv: Use RISCVException as return type for all csr ops, Alistair Francis, 2024/02/09
- [PULL 54/61] target/riscv: support new isa extension detection devicetree properties, Alistair Francis, 2024/02/09
- [PULL 60/61] target/riscv/cpu.c: add riscv_bare_cpu_init(), Alistair Francis, 2024/02/09
- [PULL 32/61] target/riscv: change vext_get_vlmax() arguments, Alistair Francis, 2024/02/09
- [PULL 34/61] target/riscv/cpu.c: remove cpu->cfg.vlen, Alistair Francis, 2024/02/09
- [PULL 41/61] target/riscv: FCSR doesn't contain vxrm and vxsat, Alistair Francis, 2024/02/09
- [PULL 43/61] hw/riscv/virt-acpi-build.c: fix leak in build_rhct(),
Alistair Francis <=
- [PULL 44/61] hw/riscv/numa.c: use g_autofree in socket_fdt_write_distance_matrix(), Alistair Francis, 2024/02/09
- [PULL 57/61] target/riscv: SMBIOS support for RISC-V virt machine, Alistair Francis, 2024/02/09
- [PULL 47/61] hw/riscv/virt.c: use g_autofree in create_fdt_virtio(), Alistair Francis, 2024/02/09
- [PULL 51/61] target/riscv: Check 'A' and split extensions for atomic instructions, Alistair Francis, 2024/02/09
- [PULL 53/61] target/riscv: use misa_mxl_max to populate isa string rather than TARGET_LONG_BITS, Alistair Francis, 2024/02/09
- [PULL 56/61] smbios: function to set default processor family, Alistair Francis, 2024/02/09
- [PULL 58/61] qemu-options: enable -smbios option on RISC-V, Alistair Francis, 2024/02/09
- [PULL 50/61] target/riscv: Add Zaamo and Zalrsc extension infrastructure, Alistair Francis, 2024/02/09
- Re: [PULL 00/61] riscv-to-apply queue, Peter Maydell, 2024/02/12