[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 32/34] tests/migration-test: Stick with gicv3 in aarch64 test
From: |
peterx |
Subject: |
[PULL 32/34] tests/migration-test: Stick with gicv3 in aarch64 test |
Date: |
Thu, 8 Feb 2024 11:05:26 +0800 |
From: Peter Xu <peterx@redhat.com>
Recently we introduced cross-binary migration test. It's always wanted
that migration-test uses stable guest ABI for both QEMU binaries in this
case, so that both QEMU binaries will be compatible on the migration
stream with the cmdline specified.
Switch to a static gic version "3" rather than using version "max", so that
GIC should be stable now across any future QEMU binaries for migration-test.
Here the version can actually be anything as long as the ABI is stable. We
choose "3" because it's the majority of what we already use in QEMU while
still new enough: "git grep gic-version=3" shows 6 hit, while version 4 has
no direct user yet besides "max".
Note that even with this change, aarch64 won't be able to work yet with
migration cross binary test, but then the only missing piece will be the
stable CPU model.
Reviewed-by: "Daniel P. Berrangé" <berrange@redhat.com>
Link: 20240207005403.242235-2-peterx@redhat.com">https://lore.kernel.org/r/20240207005403.242235-2-peterx@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
---
tests/qtest/migration-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 7675519cfa..8a5bb1752e 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -819,7 +819,7 @@ static int test_migrate_start(QTestState **from, QTestState
**to,
} else if (strcmp(arch, "aarch64") == 0) {
memory_size = "150M";
machine_alias = "virt";
- machine_opts = "gic-version=max";
+ machine_opts = "gic-version=3";
arch_opts = g_strdup_printf("-cpu max -kernel %s", bootpath);
start_address = ARM_TEST_MEM_START;
end_address = ARM_TEST_MEM_END;
--
2.43.0
- [PULL 24/34] migration/multifd: Optimize sender side to be lockless, (continued)
[PULL 27/34] migration/multifd: Remove p->running, peterx, 2024/02/07
[PULL 30/34] migration/multifd: Unify multifd and TLS connection paths, peterx, 2024/02/07
[PULL 32/34] tests/migration-test: Stick with gicv3 in aarch64 test,
peterx <=
[PULL 16/34] migration/multifd: Split multifd_send_terminate_threads(), peterx, 2024/02/07
[PULL 18/34] migration/multifd: Change retval of multifd_send_pages(), peterx, 2024/02/07
[PULL 29/34] migration/multifd: Move multifd_send_setup into migration thread, peterx, 2024/02/07
[PULL 28/34] migration/multifd: Move multifd_send_setup error handling in to the function, peterx, 2024/02/07
[PULL 31/34] migration/multifd: Add a synchronization point for channel creation, peterx, 2024/02/07
[PULL 33/34] ci: Remove tag dependency for build-previous-qemu, peterx, 2024/02/07
[PULL 34/34] ci: Update comment for migration-compat-aarch64, peterx, 2024/02/07
Re: [PULL 00/34] Migration staging patches, Peter Maydell, 2024/02/09