[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/15] qapi: Move @String out of common.json to discourage re
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 14/15] qapi: Move @String out of common.json to discourage reuse |
Date: |
Wed, 7 Feb 2024 08:41:28 +0000 |
User-agent: |
Mutt/2.2.12 (2023-09-09) |
On Mon, Feb 05, 2024 at 08:47:08AM +0100, Markus Armbruster wrote:
> Use of String is problematic, because it results in awkward interface
> documentation. The previous commit cleaned up one instance.
>
> Move String out of common.json next to its remaining users in net.json
> to discourage reuse elsewhere.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/common.json | 11 -----------
> qapi/net.json | 12 +++++++++++-
> include/net/filter.h | 2 +-
> 3 files changed, 12 insertions(+), 13 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 06/15] qapi: Require member documentation (with loophole), (continued)
- [PATCH 09/15] qga/qapi-schema: Plug trivial documentation holes, Markus Armbruster, 2024/02/05
- [PATCH 05/15] sphinx/qapidoc: Drop code to generate doc for simple union tag, Markus Armbruster, 2024/02/05
- [PATCH 12/15] qapi: Plug trivial documentation holes around former simple unions, Markus Armbruster, 2024/02/05
- [PATCH 14/15] qapi: Move @String out of common.json to discourage reuse, Markus Armbruster, 2024/02/05
- Re: [PATCH 14/15] qapi: Move @String out of common.json to discourage reuse,
Daniel P . Berrangé <=
- [PATCH 13/15] qapi: Improve documentation of file descriptor socket addresses, Markus Armbruster, 2024/02/05
- [PATCH 02/15] docs/devel/qapi-code-gen: Tweak doc comment whitespace, Markus Armbruster, 2024/02/05
- [PATCH 01/15] docs/devel/qapi-code-gen: Normalize version refs x.y.0 to just x.y, Markus Armbruster, 2024/02/05
- [PATCH 03/15] qapi/block-core: Fix BlockLatencyHistogramInfo doc markup, Markus Armbruster, 2024/02/05
- [PATCH 15/15] qapi: Add missing union tag documentation, Markus Armbruster, 2024/02/05