qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 4/6] util/bufferiszero: remove useless prefetches


From: Richard Henderson
Subject: Re: [PATCH v3 4/6] util/bufferiszero: remove useless prefetches
Date: Wed, 7 Feb 2024 08:29:18 +1000
User-agent: Mozilla Thunderbird

On 2/7/24 06:48, Alexander Monakov wrote:
Use of prefetching in bufferiszero.c is quite questionable:

- prefetches are issued just a few CPU cycles before the corresponding
   line would be hit by demand loads;

- they are done for simple access patterns, i.e. where hardware
   prefetchers can perform better;

- they compete for load ports in loops that should be limited by load
   port throughput rather than ALU throughput.

Signed-off-by: Alexander Monakov<amonakov@ispras.ru>
Signed-off-by: Mikhail Romanov<mmromanov@ispras.ru>
---
  util/bufferiszero.c | 3 ---
  1 file changed, 3 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]