Re: [PATCH v8 1/5] ebpf: Added eBPF map update through mmap.

[Andrew Melnichenko]

Hi all,
I'll revert the license changes and leave SPDX ids only for new files.

On Tue, Jan 30, 2024 at 12:38 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Thu, Jan 25, 2024 at 03:06:50PM +0200, Andrew Melnychenko wrote:
> > Changed eBPF map updates through mmaped array.
> > Mmaped arrays provide direct access to map data.
> > It should omit using bpf_map_update_elem() call,
> > which may require capabilities that are not present.
> >
> > Signed-off-by: Andrew Melnychenko <andrew@daynix.com>
> > ---
> >  ebpf/ebpf_rss.c | 120 ++++++++++++++++++++++++++++++++++++++----------
> >  ebpf/ebpf_rss.h |   8 +++-
> >  2 files changed, 101 insertions(+), 27 deletions(-)
> >
> > diff --git a/ebpf/ebpf_rss.c b/ebpf/ebpf_rss.c
> > index cee658c158..c6e10265a7 100644
> > --- a/ebpf/ebpf_rss.c
> > +++ b/ebpf/ebpf_rss.c
> > @@ -7,8 +7,7 @@
> >   *  Andrew Melnychenko <andrew@daynix.com>
> >   *  Yuri Benditovich <yuri.benditovich@daynix.com>
> >   *
> > - * This work is licensed under the terms of the GNU GPL, version 2.  See
> > - * the COPYING file in the top-level directory.
> > + * SPDX-License-Identifier: GPL-2.0-or-later
>
>
> > diff --git a/ebpf/ebpf_rss.h b/ebpf/ebpf_rss.h
> > index bf3f2572c7..404cf53613 100644
> > --- a/ebpf/ebpf_rss.h
> > +++ b/ebpf/ebpf_rss.h
> > @@ -7,8 +7,7 @@
> >   *  Andrew Melnychenko <andrew@daynix.com>
> >   *  Yuri Benditovich <yuri.benditovich@daynix.com>
> >   *
> > - * This work is licensed under the terms of the GNU GPL, version 2.  See
> > - * the COPYING file in the top-level directory.
> > + * SPDX-License-Identifier: GPL-2.0-or-later
> >   */
> >
> >  #ifndef QEMU_EBPF_RSS_H
>
> Thee are changing the file license. This *must* be done as a
> standalone commit and show agreement from all contributors
> who could hold copyright over the code. Fortunately I only
> see one other contributor to these file, and the scope of
> their change isn't copyrightable IMHO.
>
>
>
> With regards,
> Daniel
> --
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
>