qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 00/47] nic-config.for-upstream queue


From: Peter Maydell
Subject: Re: [PULL 00/47] nic-config.for-upstream queue
Date: Mon, 5 Feb 2024 10:55:59 +0000

On Mon, 5 Feb 2024 at 10:11, Thomas Huth <thuth@redhat.com> wrote:
>
> On 05/02/2024 07.56, Thomas Huth wrote:
> > On 02/02/2024 16.40, Peter Maydell wrote:
> >> On Fri, 2 Feb 2024 at 15:36, David Woodhouse <dwmw2@infradead.org> wrote:
> >>>
> >>> On Fri, 2024-02-02 at 15:32 +0000, Peter Maydell wrote:
> >>>>
> >>>> This fails "make check' because some of the qom-test and
> >>>> test-hmp checks fail when the QEMU binary segfaults.
> >>>>
> >>>> https://gitlab.com/qemu-project/qemu/-/jobs/6084552256
> >>>> https://gitlab.com/qemu-project/qemu/-/jobs/6084044180
> >>>
> >>> Thanks.  Any idea why that didn't show up in my own pipeline?
> >>> https://gitlab.com/dwmw2/qemu/-/pipelines/1160949234
> >>
> >> I think because the failing runners are the aarch64 and
> >> s390 host ones, which we don't let run for anything
> >> except real merge-pullreq test runs because they're
> >> limited resource. I guess that perhaps we have at some point
> >> said "we don't need to run all the guest architectures
> >> on all jobs"
> >
> > It's rather "we cannot run all the guest architectures on all jobs due to
> > time constraints"
>
> Ah, wait, but we should still run at least "make check" for each target
> architecture...

Yes, this is what I mean -- it's OK to have the target
architecture checks split up between different CI jobs
as long as between the jobs we cover them all, but it's
not so good to be relying on the non-x86 host jobs to
provide part of the coverage.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]