[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 13/23] migration/multifd: Move header prepare/fill into se
From: |
Fabiano Rosas |
Subject: |
Re: [PATCH v2 13/23] migration/multifd: Move header prepare/fill into send_prepare() |
Date: |
Fri, 02 Feb 2024 16:26:39 -0300 |
peterx@redhat.com writes:
> From: Peter Xu <peterx@redhat.com>
>
> This patch redefines the interfacing of ->send_prepare(). It further
> simplifies multifd_send_thread() especially on zero copy.
>
> Now with the new interface, we require the hook to do all the work for
> preparing the IOVs to send. After it's completed, the IOVs should be ready
> to be dumped into the specific multifd QIOChannel later.
>
> So now the API looks like:
>
> p->pages -----------> send_prepare() -------------> IOVs
>
> This also prepares for the case where the input can be extended to even not
> any p->pages. But that's for later.
>
> This patch will achieve similar goal of what Fabiano used to propose here:
>
> https://lore.kernel.org/r/20240126221943.26628-1-farosas@suse.de
>
> However the send() interface may not be necessary. I'm boldly attaching a
> "Co-developed-by" for Fabiano.
>
> Co-developed-by: Fabiano Rosas <farosas@suse.de>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
- Re: [External] [PATCH v2 05/23] migration/multifd: Drop MultiFDSendParams.normal[] array, (continued)
- [PATCH v2 06/23] migration/multifd: Separate SYNC request with normal jobs, peterx, 2024/02/02
- [PATCH v2 07/23] migration/multifd: Simplify locking in sender thread, peterx, 2024/02/02
- [PATCH v2 08/23] migration/multifd: Drop pages->num check in sender thread, peterx, 2024/02/02
- [PATCH v2 09/23] migration/multifd: Rename p->num_packets and clean it up, peterx, 2024/02/02
- [PATCH v2 10/23] migration/multifd: Move total_normal_pages accounting, peterx, 2024/02/02
- [PATCH v2 11/23] migration/multifd: Move trace_multifd_send|recv(), peterx, 2024/02/02
- [PATCH v2 13/23] migration/multifd: Move header prepare/fill into send_prepare(), peterx, 2024/02/02
- Re: [PATCH v2 13/23] migration/multifd: Move header prepare/fill into send_prepare(),
Fabiano Rosas <=
- [PATCH v2 12/23] migration/multifd: multifd_send_prepare_header(), peterx, 2024/02/02
- [PATCH v2 14/23] migration/multifd: Forbid spurious wakeups, peterx, 2024/02/02
- [PATCH v2 15/23] migration/multifd: Split multifd_send_terminate_threads(), peterx, 2024/02/02
- [PATCH v2 17/23] migration/multifd: Change retval of multifd_send_pages(), peterx, 2024/02/02
- [PATCH v2 16/23] migration/multifd: Change retval of multifd_queue_page(), peterx, 2024/02/02
- [PATCH v2 18/23] migration/multifd: Rewrite multifd_queue_page(), peterx, 2024/02/02