[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 02/20] qapi/schema: add pylint suppressions
From: |
John Snow |
Subject: |
[PATCH v3 02/20] qapi/schema: add pylint suppressions |
Date: |
Thu, 1 Feb 2024 17:42:28 -0500 |
With this patch, pylint is happy with the file, so enable it in the
configuration.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
scripts/qapi/pylintrc | 5 -----
scripts/qapi/schema.py | 5 +++++
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
index 1342412c3cf..c028a1f9f51 100644
--- a/scripts/qapi/pylintrc
+++ b/scripts/qapi/pylintrc
@@ -1,10 +1,5 @@
[MASTER]
-# Add files or directories matching the regex patterns to the ignore list.
-# The regex matches against base names, not paths.
-ignore-patterns=schema.py,
-
-
[MESSAGES CONTROL]
# Disable the message, report, category or checker with the given id(s). You
diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py
index 6a836950a9a..b7830672e57 100644
--- a/scripts/qapi/schema.py
+++ b/scripts/qapi/schema.py
@@ -12,6 +12,8 @@
# This work is licensed under the terms of the GNU GPL, version 2.
# See the COPYING file in the top-level directory.
+# pylint: disable=too-many-lines
+
# TODO catching name collisions in generated code would be nice
from collections import OrderedDict
@@ -83,6 +85,7 @@ def c_name(self):
return c_name(self.name)
def check(self, schema):
+ # pylint: disable=unused-argument
assert not self._checked
seen = {}
for f in self.features:
@@ -117,6 +120,7 @@ def is_implicit(self):
return not self.info
def visit(self, visitor):
+ # pylint: disable=unused-argument
assert self._checked
def describe(self):
@@ -135,6 +139,7 @@ def visit_module(self, name):
pass
def visit_needed(self, entity):
+ # pylint: disable=unused-argument
# Default to visiting everything
return True
--
2.43.0
- Re: [PATCH v3 09/20] qapi/schema: assert resolve_type has 'info' and 'what' args on error, (continued)
- [PATCH v3 04/20] qapi/schema: declare type for QAPISchemaObjectTypeMember.type, John Snow, 2024/02/01
- [PATCH v3 07/20] qapi/schema: adjust type narrowing for mypy's benefit, John Snow, 2024/02/01
- [PATCH v3 06/20] qapi/schema: make c_type() and json_type() abstract methods, John Snow, 2024/02/01
- [PATCH v3 12/20] qapi/schema: assert info is present when necessary, John Snow, 2024/02/01
- [PATCH v3 13/20] qapi/schema: split "checked" field into "checking" and "checked", John Snow, 2024/02/01
- [PATCH v3 01/20] qapi: sort pylint suppressions, John Snow, 2024/02/01
- [PATCH v3 14/20] qapi/schema: Don't initialize "members" with `None`, John Snow, 2024/02/01
- [PATCH v3 02/20] qapi/schema: add pylint suppressions,
John Snow <=
- [PATCH v3 16/20] qapi/schema: assert inner type of QAPISchemaVariants in check_clash(), John Snow, 2024/02/01
- [PATCH v3 17/20] qapi/parser: demote QAPIExpression to Dict[str, Any], John Snow, 2024/02/01
- [PATCH v3 19/20] qapi/schema: turn on mypy strictness, John Snow, 2024/02/01
- [PATCH v3 20/20] qapi/schema: remove unnecessary asserts, John Snow, 2024/02/01
- [PATCH v3 05/20] qapi/schema: declare type for QAPISchemaArrayType.element_type, John Snow, 2024/02/01
- [PATCH v3 18/20] qapi/schema: add type hints, John Snow, 2024/02/01
- [PATCH v3 15/20] qapi/schema: fix typing for QAPISchemaVariants.tag_member, John Snow, 2024/02/01
- [PATCH v3 11/20] qapi/schema: fix QAPISchemaArrayType.check's call to resolve_type, John Snow, 2024/02/01
- [PATCH v3 08/20] qapi/schema: add type narrowing to lookup_type(), John Snow, 2024/02/01