[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/5] Revert "hw/elf_ops: Ignore loadable segments with zero s
From: |
Peter Maydell |
Subject: |
Re: [PATCH 4/5] Revert "hw/elf_ops: Ignore loadable segments with zero size" |
Date: |
Thu, 1 Feb 2024 13:01:29 +0000 |
On Thu, 1 Feb 2024 at 12:30, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> This regressed qemu-system-xtensa:
>
> TEST test_load_store on xtensa
> qemu-system-xtensa: Some ROM regions are overlapping
> These ROM regions might have been loaded by direct user request or by
> default.
> They could be BIOS/firmware images, a guest kernel, initrd or some other
> file loaded into guest memory.
> Check whether you intended to load all this guest code, and whether it has
> been built to load to the correct addresses.
>
> The following two regions overlap (in the memory address space):
> test_load_store ELF program header segment 1 (addresses
> 0x0000000000001000 - 0x0000000000001f26)
> test_load_store ELF program header segment 2 (addresses
> 0x0000000000001ab8 - 0x0000000000001ab8)
Hmm -- this second segment is zero length, so why did we create
a ROM blob for it? The commit being reverted here looks like it
ought to be expanding the set of things for which we say
"zero size, ignore entirely"...
Anyway, revert given we have a regression is the first thing
to do if there's not an immediately obvious fix.
-- PMM
- [PATCH 0/5] maintainer updates for 9.0 (docker, plugin tests, deprecation, elf, semihosting), Alex Bennée, 2024/02/01
- [PATCH 2/5] docs: mark CRIS support as deprecated, Alex Bennée, 2024/02/01
- [PATCH 3/5] configure: run plugin TCG tests again, Alex Bennée, 2024/02/01
- [PATCH 1/5] tests/docker: Add sqlite3 module to openSUSE Leap container, Alex Bennée, 2024/02/01
- [PATCH 4/5] Revert "hw/elf_ops: Ignore loadable segments with zero size", Alex Bennée, 2024/02/01
- [PATCH 5/5] kconfig: use "select" to enable semihosting, Alex Bennée, 2024/02/01