Re: [PATCH v2 1/2] igb: fix link state on resume

[Jason Wang]

On Wed, Jan 24, 2024 at 6:30 PM Laurent Vivier <lvivier@redhat.com> wrote:
>
> On resume igb_vm_state_change() always calls igb_autoneg_resume()
> that sets link_down to false, and thus activates the link even
> if we have disabled it.
>
> The problem can be reproduced starting qemu in paused state (-S) and
> then set the link to down. When we resume the machine the link appears
> to be up.
>
> Reproducer:
>
>    # qemu-system-x86_64 ... -device igb,netdev=netdev0,id=net0 -S
>
>    {"execute": "qmp_capabilities" }
>    {"execute": "set_link", "arguments": {"name": "net0", "up": false}}
>    {"execute": "cont" }
>
> To fix the problem, merge the content of igb_vm_state_change()
> into igb_core_post_load() as e1000 does.
>
> Buglink: https://issues.redhat.com/browse/RHEL-21867
> Fixes: 3a977deebe6b ("Intrdocue igb device emulation")
> Cc: akihiko.odaki@daynix.com
> Suggested-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
>
> Notes:
>     v2: Add Fixes: and a comment about igb_intrmgr_resume() purpose.
>

Queued.

Thanks