[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/14] migration/multifd: Drop MultiFDSendParams.normal[] arr
From: |
Fabiano Rosas |
Subject: |
Re: [PATCH 05/14] migration/multifd: Drop MultiFDSendParams.normal[] array |
Date: |
Wed, 31 Jan 2024 13:02:54 -0300 |
peterx@redhat.com writes:
> From: Peter Xu <peterx@redhat.com>
>
> This array is redundant when p->pages exists. Now we extended the life of
> p->pages to the whole period where pending_job is set, it should be safe to
> always use p->pages->offset[] rather than p->normal[]. Drop the array.
>
> Alongside, the normal_num is also redundant, which is the same to
> p->pages->num.
>
> This doesn't apply to recv side, because there's no extra buffering on recv
> side, so p->normal[] array is still needed.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
- [PATCH 02/14] migration/multifd: multifd_send_kick_main(), (continued)
- [PATCH 02/14] migration/multifd: multifd_send_kick_main(), peterx, 2024/01/31
- [PATCH 03/14] migration/multifd: Drop MultiFDSendParams.quit, cleanup error paths, peterx, 2024/01/31
- [PATCH 04/14] migration/multifd: Postpone reset of MultiFDPages_t, peterx, 2024/01/31
- [PATCH 06/14] migration/multifd: Separate SYNC request with normal jobs, peterx, 2024/01/31
- [PATCH 07/14] migration/multifd: Simplify locking in sender thread, peterx, 2024/01/31
- [PATCH 05/14] migration/multifd: Drop MultiFDSendParams.normal[] array, peterx, 2024/01/31
- Re: [PATCH 05/14] migration/multifd: Drop MultiFDSendParams.normal[] array,
Fabiano Rosas <=
- [PATCH 08/14] migration/multifd: Drop pages->num check in sender thread, peterx, 2024/01/31
- [PATCH 10/14] migration/multifd: Move total_normal_pages accounting, peterx, 2024/01/31
- [PATCH 11/14] migration/multifd: Move trace_multifd_send|recv(), peterx, 2024/01/31
- [PATCH 09/14] migration/multifd: Rename p->num_packets and clean it up, peterx, 2024/01/31
- [PATCH 12/14] migration/multifd: multifd_send_prepare_header(), peterx, 2024/01/31