Re: [PATCH v3 23/33] linux-user: Split out mmap_h_gt_g

[Ilya Leoshkevich]

On Tue, Jan 02, 2024 at 12:57:58PM +1100, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  linux-user/mmap.c | 288 ++++++++++++++++++++++------------------------
>  1 file changed, 139 insertions(+), 149 deletions(-)
> 
> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
> index 8b0a26e50d..552656edd4 100644
> --- a/linux-user/mmap.c
> +++ b/linux-user/mmap.c

[...]

> +    if (last < real_last) {
> +        abi_ulong real_page_start = real_last - host_page_size + 1;
> +        if (!mmap_frag(real_page_start, real_page_start, last,
> +                       target_prot, flags, fd,
> +                       offset + real_page_start - start)) {

Should we unmap start here and in a few places below?

[...]