[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] qapi: Drop redundant documentation of inherited members
From: |
Eric Blake |
Subject: |
Re: [PATCH 1/5] qapi: Drop redundant documentation of inherited members |
Date: |
Mon, 29 Jan 2024 13:46:34 -0600 |
User-agent: |
NeoMutt/20231221 |
On Mon, Jan 29, 2024 at 12:50:04PM +0100, Markus Armbruster wrote:
> Documentation generated for SchemaInfo looks like
>
> The members of "SchemaInfoBuiltin" when "meta-type" is ""builtin""
> The members of "SchemaInfoEnum" when "meta-type" is ""enum""
> The members of "SchemaInfoArray" when "meta-type" is ""array""
> The members of "SchemaInfoObject" when "meta-type" is ""object""
> The members of "SchemaInfoAlternate" when "meta-type" is ""alternate""
> The members of "SchemaInfoCommand" when "meta-type" is ""command""
> The members of "SchemaInfoEvent" when "meta-type" is ""event""
> Additional members depend on the value of "meta-type".
>
> The last line became redundant when commit 88f63467c57 (qapi2texi:
> Generate reference to base type members) added the lines preceding it.
> Drop it.
>
> BlockdevOptions has the same issue. Drop
>
> Remaining options are determined by the block driver.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/block-core.json | 2 --
> qapi/introspect.json | 2 --
> 2 files changed, 4 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
- [PATCH 0/5] qmp: Documentation cleanups, Markus Armbruster, 2024/01/29
- [PATCH 4/5] qga: Move type description right after type name, Markus Armbruster, 2024/01/29
- [PATCH 2/5] qapi: Drop redundant documentation of conditional, Markus Armbruster, 2024/01/29
- [PATCH 1/5] qapi: Drop redundant documentation of inherited members, Markus Armbruster, 2024/01/29
- Re: [PATCH 1/5] qapi: Drop redundant documentation of inherited members,
Eric Blake <=
- [PATCH 5/5] qga/qapi-schema: Move command description right after command name, Markus Armbruster, 2024/01/29
- [PATCH 3/5] qapi: Elide "Potential additional modes" from generated docs, Markus Armbruster, 2024/01/29