[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/14] migration: Take reference to migration state around bg_migr
From: |
peterx |
Subject: |
[PULL 10/14] migration: Take reference to migration state around bg_migration_vm_start_bh |
Date: |
Mon, 29 Jan 2024 11:04:01 +0800 |
From: Fabiano Rosas <farosas@suse.de>
We need to hold a reference to the current_migration object around
async calls to avoid it been freed while still in use.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Link: 20240119233922.32588-3-farosas@suse.de">https://lore.kernel.org/r/20240119233922.32588-3-farosas@suse.de
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/migration.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index cf17b68e57..b1213b59ce 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -3382,6 +3382,7 @@ static void bg_migration_vm_start_bh(void *opaque)
vm_resume(s->vm_old_state);
migration_downtime_end(s);
+ object_unref(OBJECT(s));
}
/**
@@ -3486,6 +3487,7 @@ static void *bg_migration_thread(void *opaque)
* writes to virtio VQs memory which is in write-protected region.
*/
s->vm_start_bh = qemu_bh_new(bg_migration_vm_start_bh, s);
+ object_ref(OBJECT(s));
qemu_bh_schedule(s->vm_start_bh);
bql_unlock();
--
2.43.0
- [PULL 00/14] Migration 20240126 patches, peterx, 2024/01/28
- [PULL 01/14] userfaultfd: use 1ULL to build ioctl masks, peterx, 2024/01/28
- [PULL 02/14] migration: Plug memory leak on HMP migrate error path, peterx, 2024/01/28
- [PULL 03/14] migration: Make threshold_size an uint64_t, peterx, 2024/01/28
- [PULL 05/14] analyze-migration.py: Remove trick on parsing ramblocks, peterx, 2024/01/28
- [PULL 04/14] migration: Drop unnecessary check in ram's pending_exact(), peterx, 2024/01/28
- [PULL 06/14] ci: Add a migration compatibility test job, peterx, 2024/01/28
- [PULL 07/14] ci: Disable migration compatibility tests for aarch64, peterx, 2024/01/28
- [PULL 08/14] migration/yank: Use channel features, peterx, 2024/01/28
- [PULL 09/14] migration: Fix use-after-free of migration state object, peterx, 2024/01/28
- [PULL 10/14] migration: Take reference to migration state around bg_migration_vm_start_bh,
peterx <=
- [PULL 11/14] migration: Reference migration state around loadvm_postcopy_handle_run_bh, peterx, 2024/01/28
- [PULL 12/14] migration: Add a wrapper to qemu_bh_schedule, peterx, 2024/01/28
- [PULL 13/14] migration: Centralize BH creation and dispatch, peterx, 2024/01/28
- [PULL 14/14] Make 'uri' optional for migrate QAPI, peterx, 2024/01/28
- Re: [PULL 00/14] Migration 20240126 patches, Peter Maydell, 2024/01/29