Re: [PATCH v11 02/11] hw/fsi: Introduce IBM's scratchpad device

[Ninad Palsule]

Hello Cedric,


> >   +static uint64_t fsi_scratchpad_read(void *opaque, hwaddr addr, 
> > unsigned size)
> > +{
> > +    FSIScratchPad *s = SCRATCHPAD(opaque);
> > +    int reg = TO_REG(addr);
> > +
> > +    trace_fsi_scratchpad_read(addr, size);
> > +
> > +    if (reg >= FSI_SCRATCHPAD_NR_REGS) {
>
> usually, the model logs a GUEST_ERROR in such case, specially when the 
> MMIO
> window is larger than the register set. Same comment for the write memop.
>
> with that,
>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>

Added error log. Added tag.

Thanks for the review.

Regards,

Ninad