Re: [PATCH v5 4/4] accel/tcg: Move perf and debuginfo support to tcg

[Philippe Mathieu-Daudé]

On 25/1/24 04:04, Ilya Leoshkevich wrote:
> On Thu, 2024-01-25 at 07:11 +1000, Richard Henderson wrote:
> > On 1/24/24 17:56, Philippe Mathieu-Daudé wrote:
> > > From: Ilya Leoshkevich <iii@linux.ibm.com>
> > >
> > > tcg/ should not depend on accel/tcg/, but perf and debuginfo
> > > support provided by the latter are being used by tcg/tcg.c.
> > >
> > > Since that's the only user, move both to tcg/.
> > >
> > > Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> > > Message-ID: <20231208003754.3688038-5-iii@linux.ibm.com>
> > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > > ---
> > >    {accel/tcg => tcg}/debuginfo.h | 4 ++--
> > >    {accel/tcg => tcg}/perf.h      | 4 ++--
> >
> > Headers should be in include/tcg/.
> >
> > > --- a/accel/tcg/translate-all.c
> > > +++ b/accel/tcg/translate-all.c
> > > @@ -63,7 +63,7 @@
> > >    #include "tb-context.h"
> > >    #include "internal-common.h"
> > >    #include "internal-target.h"
> > > -#include "perf.h"
> > > +#include "tcg/perf.h"
> >
> > Since it is used from accel/tcg/,
> >
> > >    #include "tcg/insn-start-words.h"
> > >    
> > >    TBContext tb_ctx;
> > > diff --git a/hw/core/loader.c b/hw/core/loader.c
> > > index e7a9b3775b..b8e52f3fb0 100644
> > > --- a/hw/core/loader.c
> > > +++ b/hw/core/loader.c
> > > @@ -62,7 +62,7 @@
> > >    #include "hw/boards.h"
> > >    #include "qemu/cutils.h"
> > >    #include "sysemu/runstate.h"
> > > -#include "accel/tcg/debuginfo.h"
> > > +#include "tcg/debuginfo.h"
> >
> > ... and hw/core/.
> >
> > Otherwise,
> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> >
> > r~
>
> Can it be that this is the rebased v3?
> v4 seems to have these issues fixed:
>
> https://patchew.org/QEMU/20231212003837.64090-1-iii@linux.ibm.com/

Indeed 🤦‍♂️ v6 on the way...