[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/15] Hexagon (target/hexagon) Remove unused WRITES_PRED_REG attr
From: |
Brian Cain |
Subject: |
[PULL 10/15] Hexagon (target/hexagon) Remove unused WRITES_PRED_REG attribute |
Date: |
Sun, 21 Jan 2024 22:34:56 -0800 |
From: Taylor Simpson <ltaylorsimpson@gmail.com>
This is the only remaining use of the is_written function. We will
remove it in the subsequent commit.
Signed-off-by: Taylor Simpson <ltaylorsimpson@gmail.com>
Reviewed-by: Brian Cain <bcain@quicinc.com>
Message-Id: <20231210220712.491494-9-ltaylorsimpson@gmail.com>
Signed-off-by: Brian Cain <bcain@quicinc.com>
---
target/hexagon/attribs_def.h.inc | 1 -
target/hexagon/hex_common.py | 11 -----------
2 files changed, 12 deletions(-)
diff --git a/target/hexagon/attribs_def.h.inc b/target/hexagon/attribs_def.h.inc
index 21d457fa4a..87942d46f4 100644
--- a/target/hexagon/attribs_def.h.inc
+++ b/target/hexagon/attribs_def.h.inc
@@ -117,7 +117,6 @@ DEF_ATTRIB(IMPLICIT_READS_P1, "Reads the P1 register", "",
"")
DEF_ATTRIB(IMPLICIT_READS_P2, "Reads the P2 register", "", "")
DEF_ATTRIB(IMPLICIT_READS_P3, "Reads the P3 register", "", "")
DEF_ATTRIB(IMPLICIT_WRITES_USR, "May write USR", "", "")
-DEF_ATTRIB(WRITES_PRED_REG, "Writes a predicate register", "", "")
DEF_ATTRIB(COMMUTES, "The operation is communitive", "", "")
DEF_ATTRIB(DEALLOCRET, "dealloc_return", "", "")
DEF_ATTRIB(DEALLOCFRAME, "deallocframe", "", "")
diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py
index 4565dd1953..ca5e9630c1 100755
--- a/target/hexagon/hex_common.py
+++ b/target/hexagon/hex_common.py
@@ -94,10 +94,6 @@ def is_cond_call(tag):
def calculate_attribs():
add_qemu_macro_attrib("fREAD_PC", "A_IMPLICIT_READS_PC")
add_qemu_macro_attrib("fTRAP", "A_IMPLICIT_READS_PC")
- add_qemu_macro_attrib("fWRITE_P0", "A_WRITES_PRED_REG")
- add_qemu_macro_attrib("fWRITE_P1", "A_WRITES_PRED_REG")
- add_qemu_macro_attrib("fWRITE_P2", "A_WRITES_PRED_REG")
- add_qemu_macro_attrib("fWRITE_P3", "A_WRITES_PRED_REG")
add_qemu_macro_attrib("fSET_OVERFLOW", "A_IMPLICIT_WRITES_USR")
add_qemu_macro_attrib("fSET_LPCFG", "A_IMPLICIT_WRITES_USR")
add_qemu_macro_attrib("fLOAD", "A_SCALAR_LOAD")
@@ -122,13 +118,6 @@ def calculate_attribs():
continue
macro = macros[macname]
attribdict[tag] |= set(macro.attribs)
- # Figure out which instructions write predicate registers
- tagregs = get_tagregs()
- for tag in tags:
- regs = tagregs[tag]
- for regtype, regid in regs:
- if regtype == "P" and is_written(regid):
- attribdict[tag].add("A_WRITES_PRED_REG")
# Mark conditional jumps and calls
# Not all instructions are properly marked with A_CONDEXEC
for tag in tags:
--
2.25.1
- [PULL 00/15] target-hexagon queue, hexagon docker, Brian Cain, 2024/01/22
- [PULL 05/15] Hexagon (target/hexagon) Make generators object oriented - gen_helper_protos, Brian Cain, 2024/01/22
- [PULL 03/15] Hexagon (target/hexagon) Clean up handling of modifier registers, Brian Cain, 2024/01/22
- [PULL 07/15] Hexagon (target/hexagon) Make generators object oriented - gen_idef_parser_funcs, Brian Cain, 2024/01/22
- [PULL 02/15] Hexagon (target/hexagon) Fix shadow variable when idef-parser is off, Brian Cain, 2024/01/22
- [PULL 08/15] Hexagon (target/hexagon) Make generators object oriented - gen_op_regs, Brian Cain, 2024/01/22
- [PULL 13/15] Hexagon (target/hexagon) Use QEMU decodetree (16-bit instructions), Brian Cain, 2024/01/22
- [PULL 09/15] Hexagon (target/hexagon) Make generators object oriented - gen_analyze_funcs, Brian Cain, 2024/01/22
- [PULL 15/15] target/hexagon: reduce scope of def_regnum, remove dead assignment, Brian Cain, 2024/01/22
- [PULL 01/15] tests/docker: Hexagon toolchain update, Brian Cain, 2024/01/22
- [PULL 10/15] Hexagon (target/hexagon) Remove unused WRITES_PRED_REG attribute,
Brian Cain <=
- [PULL 14/15] Hexagon (target/hexagon) Remove old dectree.py, Brian Cain, 2024/01/22
- [PULL 12/15] Hexagon (target/hexagon) Use QEMU decodetree (32-bit instructions), Brian Cain, 2024/01/22
- [PULL 04/15] Hexagon (target/hexagon) Make generators object oriented - gen_tcg_funcs, Brian Cain, 2024/01/22
- [PULL 06/15] Hexagon (target/hexagon) Make generators object oriented - gen_helper_funcs, Brian Cain, 2024/01/22
- [PULL 11/15] Hexagon (target/hexagon) Remove dead functions from hex_common.py, Brian Cain, 2024/01/22
- Re: [PULL 00/15] target-hexagon queue, hexagon docker, Peter Maydell, 2024/01/23